fix: regression with migrate command#1423
Closed
jamesgeorge007 wants to merge 3 commits into
Closed
Conversation
webpack-bot
added
PR: reviewed-changes-requested
PR: review-outdated
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
It is change webpack.config.js content after tests?
jamesgeorge007
force-pushed
the
hotfix/migrate
branch
from
April 6, 2020 13:27
a3093bd to
d4a919f
Compare
Contributor
Author
That would require us to bypass the prompts for the entire process to complete. As of now, we're checking against the very first user prompt. |
Member
We should do it, because other steps can be broken too |
jamesgeorge007
force-pushed
the
hotfix/migrate
branch
3 times, most recently
from
April 8, 2020 14:42
7fdc5cd to
ddb7622
Compare
jamesgeorge007
force-pushed
the
hotfix/migrate
branch
5 times, most recently
from
April 20, 2020 12:39
03f6382 to
4447368
Compare
jamesgeorge007
force-pushed
the
hotfix/migrate
branch
from
April 21, 2020 03:56
4447368 to
3786f5b
Compare
jamesgeorge007
commented
Apr 21, 2020
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
The
migratecommand expects a source config file to be passed in as an argument. And for the output, we can either have it as another file or overwrite the source. Added test cases covering these scenarios.If relevant, did you update the documentation?
N/A
Summary
closes #1422
Does this PR introduce a breaking change?
Nope
Other information
N/A