Fix migrate command

[knagaitsev]

What kind of change does this PR introduce?

fix/tests

Did you add tests for your changes?

Yes (still need to add tests for runPrettier)

I'm not exactly sure how the migrate command is supposed to work. Could someone give an example of a webpack config that it should make modifications to?

If relevant, did you update the documentation?

No

Summary

@jamesgeorge007 Sorry for taking over, just couldn't debug runPromptWithAnswers without using your changes. It seems that execa does not like an empty input string option.

• Fixes runPromptWithAnswers
• Fixes migrate
• Fixes issues with runPrettier

Does this PR introduce a breaking change?

Slightly with how runPrettier works

Other information

[anshumanv]

@Loonride one test unusually still fails, doesn't show any log, can you debug?

[jamesgeorge007]

I'm not exactly sure how the migrate command is supposed to work. Could someone give an example of a webpack config that it should make modifications to?

You can find everything related to migrate command here

[knagaitsev]

It seems sending a SIGKILL to the process at the end of runPromptWithAnswers made it more stable 🤷‍♀️

[alexander-akait]

/cc @webpack/cli-team please review

[alexander-akait]

hm, ci is not stable in some cases, it is strange

[knagaitsev]

hm, ci is not stable in some cases, it is strange

whats confusing is it always either seems like a large group of them fail, or none of them fail 🤔

[rishabh3112]

whats confusing is it always either seems like a large group of them fail, or none of them fail 🤔

Others are cancelled when one of them fails. the macOS Node v13 container is the failing one in every PR:(

[knagaitsev]

Others are cancelled when one of them fails. the macOS Node v13 container is the failing one everywhere :(

Oh that makes more sense thanks

[alexander-akait]

I think we have racing

[webpack-bot]

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@jamesgeorge007 Please review the new changes.

[knagaitsev]

Let me try a few things with how runPromptWithAnswers works.

[knagaitsev]

@evilebottnawi 4 test runs good in a row, I think stabilization worked!

What I did was forced runPromptWithAnswers to wait for new stdout before writing the next answer to stdin

[alexander-akait]

Good job!