fix: ignore type inconsistency for now, fix build#1523
Merged
Conversation
anshumanv
changed the title
rishabh3112
reviewed
May 5, 2020
rishabh3112
left a comment
rishabh3112
left a comment
Contributor
There was a problem hiding this comment.
IMO skip the tests for migrate for now as migrate as a feature isn't a blocker for us.
anshumanv
marked this pull request as ready for review
May 5, 2020 05:37
Contributor
Author
|
Tests seem to pass now, I think we can let them stay |
rishabh3112
approved these changes
May 5, 2020
snitin315
approved these changes
May 5, 2020
edjustice
approved these changes
May 5, 2020
shivaylamba
approved these changes
May 5, 2020
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @shivaylamba Please review the new changes. |
Member
|
I think its good to merge. |
Member
|
Done :+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix build, there is type inconsistency with webpack@next types, this should ignore that error for now, we need to enable this once it's fixed.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information
NA