tests: add more tests for init#1508
Merged
Merged
Conversation
5 tasks
alexander-akait
previously approved these changes
Apr 29, 2020
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
/cc @webpack/cli-team
jamesgeorge007
previously approved these changes
Apr 29, 2020
Member
|
/cc @rishabh3112 Ready for merge or still WIP |
Contributor
Author
|
@jamesgeorge007 wait, it's WIP as in the title. |
Member
|
@rishabh3112 My recommendation is using |
rishabh3112
marked this pull request as draft
April 29, 2020 11:24
rishabh3112
changed the title
rishabh3112
dismissed stale reviews from jamesgeorge007 and alexander-akait
via
April 30, 2020 11:52
c4b0016
Contributor
Author
|
Build error (in the jest update PR) was also encountered here, let me see if it works when synced with next again. EDIT |
Contributor
Contributor
Author
|
Then, we can ignore types for now as migrate is not written for webpack 5. |
Contributor
|
#1523 should fix it |
Member
|
/cc @webpack/cli-team |
wizardofhogwarts
approved these changes
May 23, 2020
wizardofhogwarts
left a comment
wizardofhogwarts
left a comment
Contributor
There was a problem hiding this comment.
Lgtm. It can be merged.
snitin315
approved these changes
May 23, 2020
anshumanv
approved these changes
May 23, 2020
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
As per suggestions by evilebottnawi,
we are adding exhaustive tests for
initcommand, then refactor it if needed and then integrate it with CLI.Does this PR introduce a breaking change?
No
Other information
Part of integrating init with CLI by default (as per roadmap)
More info #1509