Skip to content

tests: check for lock file creation#1541

Closed
jamesgeorge007 wants to merge 2 commits into
webpack:nextfrom
jamesgeorge007:tests
Closed

tests: check for lock file creation#1541
jamesgeorge007 wants to merge 2 commits into
webpack:nextfrom
jamesgeorge007:tests

Conversation

@jamesgeorge007

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
test update

Did you add tests for your changes?
This is a test update.

If relevant, did you update the documentation?
Nope

Summary
Follow up of #1478

Does this PR introduce a breaking change?
Nope

Other information
N/A

@anshumanv anshumanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're doing this we need to also include init tests

@jamesgeorge007

Copy link
Copy Markdown
Contributor Author

If we're doing this we need to also include init tests

bb19844

@anshumanv anshumanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try enabling the checks for init lock as well in this PR for once? I think they pass individually but fail together, observed in plugin PR.

@anshumanv anshumanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same behavior that I got in #1478 (review) the inquirer runner util needs debugging here.

@jamesgeorge007

Copy link
Copy Markdown
Contributor Author

@anshumanv checking for node_modules directory seems to solve the issue.

@anshumanv anshumanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try checking for node_modules everywhere and enable for init-inquirer as well, let's see if it's consistent that way

@jamesgeorge007
jamesgeorge007 force-pushed the tests branch 3 times, most recently from 47de30f to 171c69b Compare May 15, 2020 12:04
@jamesgeorge007

Copy link
Copy Markdown
Contributor Author

Inconsistent behavior 🤔

@anshumanv

Copy link
Copy Markdown
Contributor

Exactly, that's why I had to leave this out

@rishabh3112

Copy link
Copy Markdown
Contributor

@anshumanv @jamesgeorge007,
I am writing this to be the common thread for anyone writing tests for scaffolding sub packages (plugin, init, loader, etc.) can refer to.

There are various sources in code that are causing the problem, some of them are:

  • Errors and inconsistency in utils written for scaffolding (used by init, plugin, etc)

  • Inconsistent install time for packages on the CI container itself.

  • Errors while installation of packages on CI, adrupts installation of packages as well as causes non generation of lock file.

So I would advice to not include tests for files and folders related to installation of packages (lockfile, node_modules, etc) until it is fixed. Meanwhile, I am trying to fix them. If you have ideas on this, you can help out by sending suggestions to my PR :).

/cc @evilebottnawi

@jamesgeorge007

Copy link
Copy Markdown
Contributor Author

Closing in regard to #1508

@jamesgeorge007
jamesgeorge007 deleted the tests branch May 24, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants