tests: check for lock file creation#1541
Conversation
anshumanv
left a comment
There was a problem hiding this comment.
If we're doing this we need to also include init tests
|
anshumanv
left a comment
There was a problem hiding this comment.
Can you try enabling the checks for init lock as well in this PR for once? I think they pass individually but fail together, observed in plugin PR.
anshumanv
left a comment
There was a problem hiding this comment.
Same behavior that I got in #1478 (review) the inquirer runner util needs debugging here.
|
@anshumanv checking for |
anshumanv
left a comment
There was a problem hiding this comment.
Try checking for node_modules everywhere and enable for init-inquirer as well, let's see if it's consistent that way
47de30f to
171c69b
Compare
|
Inconsistent behavior 🤔 |
|
Exactly, that's why I had to leave this out |
|
@anshumanv @jamesgeorge007, There are various sources in code that are causing the problem, some of them are:
So I would advice to not include tests for files and folders related to installation of packages (lockfile, node_modules, etc) until it is fixed. Meanwhile, I am trying to fix them. If you have ideas on this, you can help out by sending suggestions to my PR :). /cc @evilebottnawi |
|
Closing in regard to #1508 |
What kind of change does this PR introduce?
test update
Did you add tests for your changes?
This is a test update.
If relevant, did you update the documentation?
Nope
Summary
Follow up of #1478
Does this PR introduce a breaking change?
Nope
Other information
N/A