tests: check for the existence of webpack config file#1576
Merged
Conversation
anshumanv
approved these changes
May 23, 2020
Contributor
|
From next time, try to point things in the PR review itself instead of sending a follow up right after merge. #1508 |
Contributor
Author
|
Just spotted it after landing that one 😅 |
rishabh3112
suggested changes
May 24, 2020
rishabh3112
left a comment
rishabh3112
left a comment
Contributor
There was a problem hiding this comment.
Please change the title to more appropriately reflect the changes in PR. The addition of webpack.config.js is a major change here imo as compared to removal of one ENTER statement.
jamesgeorge007
changed the title
rishabh3112
approved these changes
May 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
Nope
Summary
webpack.config.jsis generated as a result ofinit.Does this PR introduce a breaking change?
Nope
Other information
N/A