feat(webpack-cli): add --no-hot flag#1591
Merged
Merged
Conversation
snitin315
force-pushed
the
feat/no-hot-flag
branch
from
May 27, 2020 13:24
406ae02 to
6265b10
Compare
snitin315
force-pushed
the
feat/no-hot-flag
branch
from
May 29, 2020 16:00
6265b10 to
21aca9b
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
snitin315
force-pushed
the
feat/no-hot-flag
branch
3 times, most recently
from
May 29, 2020 16:17
4640e21 to
61824ed
Compare
snitin315
force-pushed
the
feat/no-hot-flag
branch
from
June 1, 2020 12:39
61824ed to
7f62cd4
Compare
alexander-akait
previously approved these changes
Jun 1, 2020
rishabh3112
previously approved these changes
Jun 3, 2020
anshumanv
previously approved these changes
Jun 3, 2020
jamesgeorge007
approved these changes
Jun 3, 2020
jamesgeorge007
suggested changes
Jun 3, 2020
jamesgeorge007
left a comment
jamesgeorge007
left a comment
Contributor
There was a problem hiding this comment.
Left a few suggestions.
Co-authored-by: James George <jamesgeorge998001@gmail.com>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
alexander-akait
approved these changes
Jun 3, 2020
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
/cc @webpack/cli-team
anshumanv
approved these changes
Jun 3, 2020
alexander-akait
approved these changes
Jun 7, 2020
Member
Author
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
rishabh3112
approved these changes
Jun 9, 2020
jamesgeorge007
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
added
--no-hotflag.Refers #1240 #717
Fixes #1296
Does this PR introduce a breaking change?
Yes
Other information