fix(zmodel): allow type names to be used as declaration names

[ymc9]

Fixes #1399

[coderabbitai]

Walkthrough

Walkthrough

The recent changes extend the list of keywords in the language model and modify data structure field types from lowercase to uppercase. This update enhances the flexibility and consistency of type usage across the codebase, reflecting a broader and more inclusive approach to type definitions and keyword utilization.

Changes

File Path	Change Summary
.../src/zmodel.langium	Extended list of keywords for identifiers.
.../tests/e2e/type-coverage.test.ts	Changed field types from lowercase to uppercase.

Assessment against linked issues

Objective	Addressed	Explanation
Allow enums like "DateTime" in model declarations [#1399]	✅
Define enums directly in models to reduce boilerplate code [#763]	❌	The changes do not introduce a new way to define enums directly in models.
Enable strong-typed JSON fields for better data validation [#783]	❌	Changes do not address the creation of non-database related types or JSON field validation.
Multiple fields referencing the same model without validation issues [#653]	❌	The changes do not address issues related to multiple fields referencing the same model.

Possibly related issues

• [Feature Request] SQL Server Enum Support in ZenStack #763: The changes might indirectly support the issue by expanding the type system, which could later facilitate enum definitions directly in models.
• [Feature Request] Support for non-model types #783: Although the current changes do not directly address the creation of non-database related types, the expanded keyword list and type adjustments provide a foundation that could be built upon to support such features.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c7b788d and 48e59b9.

Files ignored due to path filters (4)

• package.json is excluded by !**/*.json
• packages/language/src/generated/ast.ts is excluded by !**/generated/**
• packages/language/src/generated/grammar.ts is excluded by !**/generated/**
• pnpm-lock.yaml is excluded by !pnpm-lock.yaml, !**/*.yaml

Files selected for processing (2)

• packages/language/src/zmodel.langium (1 hunks)
• tests/integration/tests/e2e/type-coverage.test.ts (2 hunks)

Additional comments not posted (3)

tests/integration/tests/e2e/type-coverage.test.ts (2)

16-23: Changes in model Foo field types from lowercase to uppercase are consistent with the new language specifications.

---

44-51: Changes in data object field names from lowercase to uppercase are consistent with the model declaration changes.

packages/language/src/zmodel.langium (1)

227-227: Expansion of RegularID to include new keywords as valid identifiers enhances flexibility and aligns with similar tools.