allow enum names to be used as declaration names

[francistogram]

Fixing bug from #1424 that errored if a special name e.g. DateTime was used in an Enum name

[coderabbitai]

Walkthrough

Walkthrough

The recent update involves a modification to the declaration of the EnumField entity within the zmodel.langium file. Specifically, the identifier name=RegularID has been renamed to name=RegularIDWithTypeNames. This adjustment likely aims to enhance clarity or functionality within the codebase.

Changes

File Path	Change Summary
packages/.../zmodel.langium	Renamed name=RegularID to name=RegularIDWithTypeNames in EnumField.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 29962e0 and 5a13d8b.

Files ignored due to path filters (2)

• packages/language/src/generated/ast.ts is excluded by !**/generated/**
• packages/language/src/generated/grammar.ts is excluded by !**/generated/**

Files selected for processing (1)

• packages/language/src/zmodel.langium (1 hunks)

Additional comments not posted (1)

packages/language/src/zmodel.langium (1)

212-212: Change from RegularID to RegularIDWithTypeNames allows more flexibility in enum names, aligning with the PR's objectives.

Verification successful

---

Verification of RegularIDWithTypeNames Integration

The change from RegularID to RegularIDWithTypeNames has been correctly integrated into the grammar and TypeScript files. The new identifier type does not conflict with existing usages of RegularID and aligns with the PR's objective to allow more flexibility in enum names.

• RegularIDWithTypeNames is used in the generated grammar and AST files.
• The integration appears consistent and does not introduce any conflicts.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the new identifier type does not conflict with other grammar rules.

# Test: Search for usage of `RegularIDWithTypeNames` and `RegularID` to ensure no conflicts.
rg --type typescript $'RegularIDWithTypeNames|RegularID'

Length of output: 92

---

---

Script:

#!/bin/bash
# Description: Verify that the new identifier type does not conflict with other grammar rules.

# Test: Search for usage of `RegularIDWithTypeNames` and `RegularID` to ensure no conflicts.
rg --type ts 'RegularIDWithTypeNames|RegularID'

Length of output: 2032