fix(project-context): canonicalize Skill IR paths in model digest - #191
Merged
Conversation
🦋 Changeset detectedLatest commit: e0436e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
PR #185 added skillIr and hostDocuments to the normalized model without extending canonicalizeNormalizedModel, so equivalent projects in different temp directories produced different modelDigest values.
ScriptedAlchemy
force-pushed
the
fix/dev-services-model-digest
branch
from
September 1, 2026 20:25
63e3415 to
e0436e6
Compare
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 1, 2026
5 tasks
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 1, 2026
… can go green (#197) * test: align hook expectations with sorted normalization (#180) and the example's semantic event route (#182) Both features merged while main CI was already red, so their outdated sibling tests were never caught: normalizeHooks now orders hooks by stable id, the rsc-agent-runtime example declares one tool/after event route instead of per-host prebuilt hooks, and the workbench therefore exposes the simulatable Hooks capability page. * fix(ci): keep route-unit proofs out of the example plain test pool * fix(ci): defer to the mainline Skill IR digest canonicalization (#191)
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 1, 2026
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 1, 2026
…ays open (#200) (#203) * fix(ci): keep route-unit proofs out of the example plain test pool * fix(ci): defer to the mainline Skill IR digest canonicalization (#191) * test: retry the overview handoff e2e while the reload-budget flake stays open (#200) Verify (Node 24) alone exceeded the owned-reload generation budget on a loaded hosted runner (run 33557117407) while the identical commit passed on Node 22 and 26 — the #122-class watch-delivery skew. Same interim treatment as #138 gave the known family.
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 1, 2026
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 1, 2026
…p) (#208) * fix(ci): keep route-unit proofs out of the example plain test pool * fix(ci): defer to the mainline Skill IR digest canonicalization (#191) * fix(state): keep the sqlite close finalizer infallible (#201 follow-up) acquireRelease release finalizers cannot carry an error channel, so the runtime package's declaration build failed on every job. A close failure on the success path now dies (still visible) instead of failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-services.test.tsregression where equivalent projects produced differentmodelDigestvalues after PR feat(skills): canonical Skill IR, token registry, and per-host lowering (#108) #185.canonicalizeNormalizedModelto root-relative canonicalize paths insideskillIrandhostDocuments(source paths, resource paths, sidecar paths, diagnostic paths).agent-bundle.Root cause
PR #185 (#185) added
skillIr,hostDocuments, andskillTreeLayouttoNormalizedSkill, butcanonicalizeNormalizedModelonly canonicalized the pre-existing skill fields. Absolute temp-directory paths leaked into the digest, so the "root-independent project context" test saw left/right fixtures diverge.Test plan
pnpm exec rstest packages/agent-bundle/tests/dev-services.test.tspnpm exec rstest packages/agent-bundle/tests/dev-artifact-service.test.ts packages/agent-bundle/tests/package-identity.test.ts packages/agent-bundle/tests/manifest.test.tspnpm typecheckpnpm lintFixes #152