Skip to content

fix(examples/rsc-agent-runtime): dedupe Runtime App reloads by emitted content (#200) - #332

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
wave/flake-root-reload
Sep 2, 2026
Merged

fix(examples/rsc-agent-runtime): dedupe Runtime App reloads by emitted content (#200)#332
ScriptedAlchemy merged 2 commits into
mainfrom
wave/flake-root-reload

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • Root cause for Flake: overview.e2e owned-reload generation budget exceeded under hosted-runner load #200, confirmed empirically: Rspack stats.hash for the App environment is NOT stable across split watch completions whose emitted bytes are identical (observed identical asset SHA-256 769426… while stats.hash drifted 14b134…cb39be…). The reload announcer deduped by stats.hash, so a load-split recompile of unchanged output minted an extra owned-reload generation — expectMonotonicOwnedReloadFrames then saw generation 3 against the two-edit budget.
  • Fix (load-immune, deterministic accounting): runtimeAppReloadPlugin now derives reload identity from the App compiler's in-memory emitted assets (length-prefixed, name-sorted SHA-256 over names and bytes). An unchanged-output recompile never announces; an unreadable asset set stays at-least-once without clobbering the retained identity. Proxy/shell generation-ordinal semantics are unchanged.
  • overview.e2e keeps its monotonicity proof and the ownedReloadGenerationBudget = 2 ceiling — now deterministic — and drops the { retry: 2 } interim from test: retry the overview handoff e2e while the reload-budget flake stays open (#200) #203. Comments updated.
  • Includes a one-line rebase repair: the overview handoff assertion now expects packageVersion in project source identity, which Finish identity migration and expose Workbench provenance #322 began surfacing (the assertion was red on unmodified main; reproduces without this branch).

Evidence

Closes #200.

Use the App compiler's in-memory asset bytes as the reload identity so split watch completions cannot spend extra generations when Rspack stats hashes drift.
The identity migration (#322) surfaces packageVersion in project source
status; the overview handoff assertion predates it on this branch's base.
@ScriptedAlchemy
ScriptedAlchemy merged commit e84ec83 into main Sep 2, 2026
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f28f873

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T23:19:21.691581Z f28f873 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flake: overview.e2e owned-reload generation budget exceeded under hosted-runner load

1 participant