Skip to content

Swift: Route compiler diagnostics through our log.#14052

Merged
AlexDenisov merged 2 commits into
mainfrom
sashabu/swift-logging-compiler
Aug 25, 2023
Merged

Swift: Route compiler diagnostics through our log.#14052
AlexDenisov merged 2 commits into
mainfrom
sashabu/swift-logging-compiler

Conversation

@sashabu

@sashabu sashabu commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Fixed version of #13869, which was reverted in #13917.

@github-actions github-actions Bot added the Swift label Aug 24, 2023
@sashabu sashabu marked this pull request as ready for review August 25, 2023 12:26
@sashabu sashabu requested a review from a team as a code owner August 25, 2023 12:26

@AlexDenisov AlexDenisov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as DCA is happy :shipit:

@sashabu

sashabu commented Aug 25, 2023

Copy link
Copy Markdown
Contributor Author

LGTM as long as DCA is happy :shipit:

Dimillian__MovieSwiftUI is timing out both before and after, even after a dca retry. Other than that, I think it looks good.

@AlexDenisov AlexDenisov merged commit 0fe7740 into main Aug 25, 2023
@AlexDenisov AlexDenisov deleted the sashabu/swift-logging-compiler branch August 25, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants