Update Concepts - Client Library - Execution Management by JanStaschulat · Pull Request #356 · micro-ROS/micro-ROS.github.io

JanStaschulat · 2021-12-14T14:41:00Z

restructed text, separate section for "Analysis of processing patterns"
extended table of contents, more fine-grained
included figures about trigger condition from the rclc Executor presentation at the ROS 2 Executor workshop.
added arxiv publication about multi-threaded executor
in Example section: added application of rclc-executor on reference system from ROS 2 Executor workshop
centered and re-sized figures
moved all figures to sub folder /png
ordered referenced in chronological order
added section on multi-threaded executor
aligned section titles in "analysis of processing patterns" and "Examples"
updated links to cbg_executor and cbg_executor_demo

…ation, minor typos

ralph-lange · 2021-12-15T15:33:41Z

I propose to remove the plans/promises for a real-time executor for rclcpp in the introduction since we finally focused on the C client library for micro-ROS only. Instead, the work on the Callback-group Level Executor (and the contributions to the StaticSingleThreadedExecutor ?) could be described/argued at the end of the page as "beyond advanced execution management mechanisms for micro-ROS, we also contributed to improving and extending the Executor concept in rclcpp for standard ROS 2 ..."

What do you think?

In general, the introduction is very long and somehow preempts Sections 2 and 3, i.e., the analyses of the rclcpp standard Executor and typical processing patterns.

…ti-threaded executor.

JanStaschulat · 2021-12-16T10:20:15Z

@ralph-lange thanks for your review. I updated the text and added also a section about the multi-threaded executor.

ralph-lange · 2021-12-16T10:30:17Z

Thank you for the updates, @JanStaschulat. I didn't get all the way through your changes yesterday and I'm now proceeding with the review.

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

…//github.com/micro-ROS/micro-ROS.github.io into feature/concepts_execution_management_update

JanStaschulat · 2021-12-16T12:03:09Z

updated the description.

…ction 'Analysis of processing patterns'

JanStaschulat · 2021-12-16T16:24:25Z

@ralph-lange the link for cbg_executor_demo is broken
https://github.com/boschresearch/ros2_demos/tree/cbg_executor_demo/cbg_executor_demo

Where is the repo?

ralph-lange · 2021-12-16T16:33:39Z

@ralph-lange the link for cbg_executor_demo is broken https://github.com/boschresearch/ros2_demos/tree/cbg_executor_demo/cbg_executor_demo

Where is the repo?

It's here now: https://github.com/ros2/examples/tree/master/rclcpp/executors/cbg_executor

JanStaschulat · 2021-12-16T16:42:19Z

@ralph-lange
all the links in the section cbg_executor API change to the source code of the cbg_executor (github/boschresearch) are also invalid.

Shall I remove the links or do you want to look for them in the ros2 repository
PR https://github.com/ros2/rclcpp/pull/1218/files?authenticity_token=9tvMNjWcL%2BQODfdvxL7NwUKnJIJNTGl3HebJixEnHQHyspazmJEEJHO0trpHiOno5pnLNvYpfz6DSwmRQh8bgQ%3D%3D&file-filters%5B%5D=.cpp
?

…o ros2/rclcpp repo

JanStaschulat · 2021-12-16T17:12:03Z

@ralph-lange all the links in the section cbg_executor API change to the source code of the cbg_executor (github/boschresearch) are also invalid.

Shall I remove the links or do you want to look for them in the ros2 repository PR https://github.com/ros2/rclcpp/pull/1218/files?authenticity_token=9tvMNjWcL%2BQODfdvxL7NwUKnJIJNTGl3HebJixEnHQHyspazmJEEJHO0trpHiOno5pnLNvYpfz6DSwmRQh8bgQ%3D%3D&file-filters%5B%5D=.cpp ?

Resolved in 920ddb2

ralph-lange · 2021-12-16T17:13:41Z

Just saw that you've already updated it. Thank you, @JanStaschulat!

JanStaschulat · 2021-12-16T17:16:12Z

@ralph-lange @pablogs9 . I have finalized updating this page. If everything is fine for you, please approve and merge.

ralph-lange

LGTM

…S/micro-ROS.github.io#357 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

…io#356 and micro-ROS/micro-ROS.github.io#357 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

…io#356 and micro-ROS/micro-ROS.github.io#357 (#229) Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

…io#356 and micro-ROS/micro-ROS.github.io#357 (#229) Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> (cherry picked from commit f8d1c84)

…io#356 and micro-ROS/micro-ROS.github.io#357 (#229) (#234) Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> (cherry picked from commit f8d1c84) Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>

restructuring of executor description, center alignment of figures

8b0a266

JanStaschulat self-assigned this Dec 14, 2021

JanStaschulat changed the title ~~Concepts: Executor description update~~ Update Concepts - Client Library - Execution Management Dec 14, 2021

JanStaschulat added 8 commits December 14, 2021 16:30

added link to Executor Workshop, multi-threaded executor arxiv public…

d06ded8

…ation, minor typos

typos

159cc44

re-ordered references in chronological order

6582fad

fixing links to ros2/rclc repo

82d184c

added figures for trigger condition

981b977

moved all png to sub-folder /png, centering all png figures.

0786452

added png files in /png subfolders to git

ee4470b

corrected figure numbering

2e379c1

JanStaschulat requested review from pablogs9 and ralph-lange December 15, 2021 15:00

fixed typo

7dc5757

pablogs9 previously approved these changes Dec 15, 2021

View reviewed changes

review Ralph (1): updated introduction

a76a6d1

JanStaschulat dismissed pablogs9’s stale review via a76a6d1 December 16, 2021 09:03

JanStaschulat added 2 commits December 16, 2021 10:35

removed motivation in section 'rclc Executor', added paragraph on mul…

0fcbf0f

…ti-threaded executor.

overall review

332ffe9

JanStaschulat added 2 commits December 16, 2021 11:42

restructured processing patterns, (LET as last pattern)

1084118

minor improvements.

15b7fbc

JanStaschulat requested a review from pablogs9 December 16, 2021 10:48

minor improvements.

51bf721

ralph-lange requested changes Dec 16, 2021

View reviewed changes

JanStaschulat and others added 3 commits December 16, 2021 12:56

Update _docs/concepts/client_library/execution_management/index.md

5ec69f6

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/concepts/client_library/execution_management/index.md

89d326e

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/concepts/client_library/execution_management/index.md

85b6846

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

JanStaschulat and others added 3 commits December 16, 2021 12:57

Update _docs/concepts/client_library/execution_management/index.md

8aca5a9

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

second review from Ralph

8e944db

Merge branch 'feature/concepts_execution_management_update' of https:…

4f104f7

…//github.com/micro-ROS/micro-ROS.github.io into feature/concepts_execution_management_update

JanStaschulat requested a review from ralph-lange December 16, 2021 12:02

JanStaschulat added 4 commits December 16, 2021 13:05

re-ordered example for embedded use-case (moved to the end)

47f6917

aligned and renamed section title of Examples to be the same as in se…

96e2ddf

…ction 'Analysis of processing patterns'

typos

b21da0c

fix broking internal link

4693bc0

corrected link for cbg_executor_demo

48bab98

replaced links to cbg_executor source code from boschresearch repo t…

920ddb2

…o ros2/rclcpp repo

ralph-lange approved these changes Dec 16, 2021

View reviewed changes

ralph-lange merged commit d7f7399 into master Dec 16, 2021

ralph-lange deleted the feature/concepts_execution_management_update branch December 16, 2021 17:17

JanStaschulat added a commit to ros2/rclc that referenced this pull request Dec 17, 2021

updating README.md see micro-ROS/micro-ROS.github.io#356 and micro-RO…

f79db48

…S/micro-ROS.github.io#357 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

JanStaschulat added a commit to ros2/rclc that referenced this pull request Dec 17, 2021

uddated documentation README.md, see also micro-ROS/micro-ROS.github.…

9f1f3e8

…io#356 and micro-ROS/micro-ROS.github.io#357 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

JanStaschulat mentioned this pull request Dec 17, 2021

uddated documentation README.md ros2/rclc#229

Merged

Uh oh!

Conversation

JanStaschulat commented Dec 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ralph-lange commented Dec 15, 2021

Uh oh!

JanStaschulat commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ralph-lange commented Dec 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanStaschulat commented Dec 16, 2021

Uh oh!

JanStaschulat commented Dec 16, 2021

Uh oh!

ralph-lange commented Dec 16, 2021

Uh oh!

JanStaschulat commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JanStaschulat commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ralph-lange commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JanStaschulat commented Dec 16, 2021

Uh oh!

ralph-lange left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JanStaschulat commented Dec 14, 2021 •

edited

Loading

JanStaschulat commented Dec 16, 2021 •

edited

Loading

JanStaschulat commented Dec 16, 2021 •

edited

Loading

JanStaschulat commented Dec 16, 2021 •

edited

Loading

ralph-lange commented Dec 16, 2021 •

edited

Loading