fix(web): keep settings inputs focused during IME composition

[Lucenx9]

What changed

Ignore IME keydowns in useCommitOnBlur using the same isComposing / keyCode === 229 guard already used by thread rename in #6281. Normal Enter and blur still commit changed values.

Why

Pressing Enter to confirm an IME candidate in a settings DraftInput currently blurs the field and saves an unfinished value. Further typing no longer reaches the input. This affects fields such as provider display names.

The shared hook covers web and desktop settings. Mobile uses separate inputs. No provider adapters, contracts, product defaults, or diagnostic settings change.

flowchart LR
    A[Enter in DraftInput] --> B{IME composition?}
    B -->|Yes| C[Keep focus and draft]
    B -->|No| D[Blur]
    D --> E[Commit changed value]

Loading

Verification

Tested the running app in local Chromium with synthetic IME keydown events on Settings → Providers → Display name. This does not claim a native OS IME or Safari test.

• Before: both isComposing=true and isComposing=false, keyCode=229 blur and save prematurely.
• After: both retain focus and leave the saved provider label unchanged. Typing can continue.
• Normal Enter and Tab still save; the committed value survives a reload.
• Targeted lint, formatting, and hook-only TypeScript checks pass. Fallow's changed-file audit passes with no introduced findings.

UI changes

PNG captures at 2×, immediately after the same synthetic composing Enter.

Before: focus is lost and the partial name has already replaced the provider label.

After: the input keeps focus and the provider label remains unchanged until a normal commit.

Before video, typing team after the composing Enter is lost:

settings-ime-before.webm

After video, typing continues and a normal Enter saves the full name:

settings-ime-after.webm

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for UI changes
• I included videos for interaction changes

Model: GPT-5. Harness: Codex in T3 Code.

Note

Fix useCommitOnBlur hook to ignore Enter during IME composition

Adds an early return in useCommitOnBlur.ts when the keyboard event is part of IME composition or uses the IME composition key code. This prevents the hook from committing and blurring the input while users are mid-composition with input methods like CJK keyboards. Non-composition Enter handling is unchanged.

^{Macroscope summarized 8f7adcf.}

Summary by CodeRabbit

• Bug Fixes
  • Improved text input behavior for IME users by preventing premature commits or field blurs when confirming composed text with the Enter key.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-06T02:27:08.406060Z	8f7adcf	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[macroscopeapp]

Approvability

Verdict: Approved at 8f7adcf

Macroscope's review found this PR approvable — The PR adds a single localized IME guard to the shared settings input hook, preserving focus and the draft during composition while leaving normal Enter and blur commits unchanged. Its runtime impact is narrow and readily accounted for, with no product-default or static-analysis changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 09db0f39-17dc-400c-85e8-d17ef17897c9

📥 Commits

Reviewing files that changed from the base of the PR and between b438447 and 8f7adcf.

📒 Files selected for processing (1)

• apps/web/src/hooks/useCommitOnBlur.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The useCommitOnBlur hook now ignores Enter key events that occur during IME composition. This prevents composition confirmation from triggering an early commit or blur.

Changes

IME commit handling

Layer / File(s)	Summary
Composition guard apps/web/src/hooks/useCommitOnBlur.ts	The onKeyDown handler returns when event.nativeEvent.isComposing is true or event.keyCode is 229.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 8f7ad

IME candidate confirmation no longer prematurely commits or blurs settings inputs, while normal Enter and blur commits remain intact. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: preserving settings input focus during IME composition.
Description check	✅ Passed	The description explains what changed, why it changed, verification results, UI evidence, and checklist completion. It is focused and complete.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}