Skip to content

fix(web): stop collapsing the composer when it loses focus - #10437

Merged
t3dotgg merged 1 commit into
mainfrom
fix/composer-collapse-on-scroll-only
Sep 7, 2026
Merged

fix(web): stop collapsing the composer when it loses focus#10437
t3dotgg merged 1 commit into
mainfrom
fix/composer-collapse-on-scroll-only

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Sep 7, 2026

Copy link
Copy Markdown
Member

Clicking a message, copying a code block, or selecting text for a citation collapsed the composer. Blur is a side effect of doing anything else on the page, not a request for more reading room. It shipped as a default in #7855 with no prior discussion, drew complaints within hours, and #9469 added a setting to turn it off instead of fixing the default.

The desktop composer now rests only when you scroll the conversation. Focus and clicks elsewhere leave it alone. The blur trigger is removed rather than defaulted off: the composerCollapseOnBlur setting, the multi-select in Settings, the selection-hold helper, and the document-level focus and pointer listeners that existed only to detect blur are gone. The Collapse composer on scroll switch stays. A stored composerCollapseOnBlur value is dropped on decode.

Mobile keeps its own focus-driven collapse, which exists for the keyboard and is unrelated.

Verification: vp test run on the contracts, desktop settings, composer layout, focus state, and timeline tests (185 passing), tsgo --noEmit in contracts, web, and desktop, and lint and format on the touched files.

Created with Claude Fable 5.1 in Claude Code.

🤖 Generated with Claude Code

Losing focus no longer rests the desktop composer. Clicking a message,
copying output, or selecting text for a citation left it collapsed and
broke the flow. Only a timeline scroll rests it now, and the blur toggle
is gone from Settings.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This changes the default desktop composer behavior by removing blur-triggered collapsing and retiring its persisted setting, while retaining scroll-triggered collapsing. Because the change affects existing user-visible defaults and settings behavior, it warrants human review.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit a12589d into main Sep 7, 2026
23 checks passed
@t3dotgg
t3dotgg deleted the fix/composer-collapse-on-scroll-only branch September 7, 2026 00:31
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.3 KiB 13.6 KiB +282 B (+2.1%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 7.0 KiB +155 B (+2.2%) 7.3 KiB
Codex Live turn WebSocket wire 6.4 KiB 6.6 KiB +127 B (+1.9%) 7.8 KiB
Codex Live turn WebSocket decoded 55.6 KiB 57.1 KiB +1.4 KiB (+2.6%) 66.4 KiB
Codex Live turn messages 11 10 −1 (−9.1%) 21
Claude Total thread wire 13.4 KiB 13.6 KiB +241 B (+1.8%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 7.0 KiB +144 B (+2.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.5 KiB +97 B (+1.5%) 7.8 KiB
Claude Live turn WebSocket decoded 56.4 KiB 57.9 KiB +1.4 KiB (+2.6%) 66.4 KiB
Claude Live turn messages 11 10 −1 (−9.1%) 21

Baseline: 42a8fd5 · PR result: bf64483 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 7, 2026
## What's Changed
* fix(clients): show feedback results in composer banners by @juliusmarminge in pingdotgg/t3code#10398
* fix(server): stop Windows terminal polling from spiking CPU by @UtkarshUsername in pingdotgg/t3code#9476
* fix(web): onboarding installs agents without needing Node or npm by @t3dotgg in pingdotgg/t3code#10402
* fix(server): allow settling threads with unanswered async questions by @t3dotgg in pingdotgg/t3code#10400
* feat(ci): ship stable releases from the latest nightly commit by @t3dotgg in pingdotgg/t3code#10410
* feat(marketing): add a nightly channel to the download page by @t3dotgg in pingdotgg/t3code#10408
* fix(web): keep settings inputs focused during IME composition by @Lucenx9 in pingdotgg/t3code#10262
* fix(server): preserve Codex reset credits during usage updates by @yashranaway in pingdotgg/t3code#10308
* docs: link the repository security reporting policy by @yashranaway in pingdotgg/t3code#10303
* fix(web): only show auto balance errors after failed checks by @maria-rcks in pingdotgg/t3code#10407
* fix(web): improve preview recording frame delivery by @maria-rcks in pingdotgg/t3code#10403
* fix(server): preserve inline provider secrets on redacted saves by @maxwellyoung in pingdotgg/t3code#10054
* fix(web, mobile): replace Apple desktop machine labels by @extoci in pingdotgg/t3code#10396
* fix(web): hide browser when the right panel starts closing by @Neel2107 in pingdotgg/t3code#10385
* fix(web): keep settings section headings description-free by @maria-rcks in pingdotgg/t3code#10415
* fix(usage): read and redeem hub reset credits through CLIProxyAPI by @juliusmarminge in pingdotgg/t3code#10395
* fix(web): deduplicate expanded tool labels and keep errors expandable by @Yash-Singh1 in pingdotgg/t3code#10420
* fix(server): skip git status scans while the index is locked by @Gigioxx in pingdotgg/t3code#9845
* fix(mcp): allow text-only preview snapshots by @juliusmarminge in pingdotgg/t3code#10232
* fix(claude): name the expired login or usage limit instead of a generic API error by @vitalyiegorov in pingdotgg/t3code#10321
* feat(mobile): queue a message while its attachment is still uploading by @juliusmarminge in pingdotgg/t3code#10404
* feat(mobile): show when an existing thread has a message waiting in the outbox by @juliusmarminge in pingdotgg/t3code#10405
* fix(codex): accept misalignment policy errors on thread resume by @realbakari in pingdotgg/t3code#10373
* fix(server): skip disabled settlement lookups by @t3dotgg in pingdotgg/t3code#10424
* fix(server): run OpenCode CLI commands sequentially by @t3dotgg in pingdotgg/t3code#10427
* feat(web): name the drop action while dragging sidebar threads by @SunkenInTime in pingdotgg/t3code#10378
* perf(web): keep the sidebar responsive during bulk thread updates by @t3dotgg in pingdotgg/t3code#10413
* fix(web): onboarding wizard now supports light mode by @t3dotgg in pingdotgg/t3code#10432
* feat(threads): dismiss async questions without replying by @t3dotgg in pingdotgg/t3code#10431
* fix(web): stop collapsing the composer when it loses focus by @t3dotgg in pingdotgg/t3code#10437
* fix(server): keep interrupted threads resumable after restarts by @maria-rcks in pingdotgg/t3code#10421

## New Contributors
* @Neel2107 made their first contribution in pingdotgg/t3code#10385
* @realbakari made their first contribution in pingdotgg/t3code#10373

**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1316...v0.0.39-nightly.20260907.1325

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260907.1325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant