fix(web): keep popup triggers steady when pressed

[dominic-r]

What changed

Keep buttons with aria-haspopup at their normal size while pressed. Ordinary buttons retain their 0.97 press scale.

Why

The reasoning menu opens on mouse-down, when its trigger is scaled down by the shared button press style. As the trigger returns to full size during opening, the popup repositions down and left.

Exclude popup triggers from that scale rule so the anchor geometry stays fixed. This applies to shared web and desktop menu/popover buttons, without changing popup positioning, focus behavior, or native mobile controls.

UI changes

Before fix:

reported-before.mp4

After fix:

reported-after.mp4

Verification

• Chromium, real TraitsPicker loaded through Vite: sampled menu bounds every animation frame while holding and releasing the trigger, across three opens. Restoring the old selector reproduced movement from (281, 193.5) to (280, 194) CSS pixels. With the fix, every sampled position remained (280, 194).
• Reasoning option selection, keyboard opening, Escape, focus return, a neighboring popover, and ordinary button press feedback passed.
• Targeted button lint and formatting checks, web typecheck, and git diff --check passed.
• Web tested in Chromium. Desktop shares the component but was not launched separately; Firefox and native mobile were not tested.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included video for interaction changes

Model: Astra. Harness: Codex.

[macroscopeapp]

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a one-line, localized CSS fix in shared Button styling. It removes the press scale only for existing popup triggers while preserving ordinary button feedback, with no schema, data, deployment, or control-flow changes.

Not approved because:

• Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

^{Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 379c5bdd-c1d4-4c8d-9b1f-548f0e97e234

📥 Commits

Reviewing files that changed from the base of the PR and between 6abdf37 and 0f6ac5b.

📒 Files selected for processing (1)

• apps/web/src/components/ui/button.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The base button variant now excludes buttons with aria-haspopup from the active press scale animation. Other buttons retain the 0.97 scale.

Changes

Button interaction behavior

Layer / File(s)	Summary
Active-state scale selector apps/web/src/components/ui/button.tsx	The active scale selector applies only when the button does not have an aria-haspopup attribute.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0f6ac

Popup-trigger buttons now remain visually stable while pressed, while ordinary buttons retain their existing press feedback. No current merge-readiness risk remains.

Suggested reviewers: maria-rcks, juliusmarminge

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The description clearly explains what changed, why the fix is needed, the UI impact, verification performed, and checklist status. It includes before-and-after UI evidence and interaction testing deta…
Title check	✅ Passed	The title clearly and concisely describes the main change: keeping popup triggers steady while pressed.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}