reprise de la PR de traduction de HMAC de Vvenance - #1145
Merged
Conversation
Co-Authored-By: Julien Palard <julien@palard.fr>
deronnax
force-pushed
the
vvenance_hmac
branch
from
February 4, 2020 22:53
b6f7ab4 to
090a499
Compare
JulienPalard
previously requested changes
Feb 4, 2020
JulienPalard
left a comment
JulienPalard
left a comment
Member
There was a problem hiding this comment.
Ah oui pas simple.
Certaines de mes propositions prennent de la liberté (de l'avance peut être, si on pousse ça upstream), mais ça ne me gêne pas d'appliquer dans la traduction une amélioration qui n'est pas encore appliquée upstream.
christopheNan
suggested changes
Feb 7, 2020
christopheNan
left a comment
christopheNan
left a comment
Contributor
There was a problem hiding this comment.
Merci pour cette contribution.
Juste quelques reformulations.
| msgstr "" | ||
| "Retourne ``a == b``. Cette fonction utilise une approche destinée à prévenir " | ||
| "l'analyse des temps de réponse en évitant les comportements de court circuit " | ||
| "basés sur le contenu, ce qui la rend appropriée pour de la cryptographie. " |
Contributor
There was a problem hiding this comment.
Suggested change
| "basés sur le contenu, ce qui la rend appropriée pour de la cryptographie. " | |
| "quel que soit le contenu, ce qui rend son utilisation appropriée en cryptographie. " |
deronnax
commented
Mar 8, 2020
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com> Co-Authored-By: Julien Palard <julien@palard.fr>
christopheNan
suggested changes
Mar 8, 2020
christopheNan
left a comment
christopheNan
left a comment
Contributor
There was a problem hiding this comment.
Précisions sur la différence en HMAC et hachage simple.
| "donnant la clé secrète. Si *msg* est présent, un appel à ``update(msg)`` est " | ||
| "effectué. *digestmod* permet de choisir l’algorithme à utiliser par l’objet " | ||
| "HMAC, il accepte un nom de fonction de hachage (peut être tout ce qui " | ||
| "convient :func:`hashlib.new`), un constructeur de fonction de hachage ou un " |
Contributor
There was a problem hiding this comment.
Suggested change
| "convient :func:`hashlib.new`), un constructeur de fonction de hachage ou un " | |
| "convient à :func:`hashlib.new`), un constructeur de fonction de hachage ou un " |
Collaborator
Author
There was a problem hiding this comment.
arf pardon. Maintenant c'est bon
JulienPalard
reviewed
Mar 8, 2020
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Collaborator
Author
|
Hop, c'est bon. @JulienPalard @christopheNan un dernier p'tit coup de review et on merge, qu'on en finisse ? |
christopheNan
previously approved these changes
Mar 20, 2020
Collaborator
Author
|
@JulienPalard je peux pas fusionner tant qu'il n'y a pas ton approbation :'(. |
Collaborator
Author
|
@christopheNan tu peux me mettre un approval, voir si ça passe ? |
christopheNan
approved these changes
Mar 29, 2020
christopheNan
dismissed
JulienPalard’s stale review
March 29, 2020 19:32
Relais passé à christopheNan
Collaborator
Author
|
Mon dieu, enfin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reprise de la PR #823. Le texte d'origine en anglais est assez aride et mériterait lui-même une correction.
closes #821