feat(careers): careers page backed by the Ashby job board by waleedlatif1 · Pull Request #5316 · simstudioai/sim

waleedlatif1 · 2026-07-01T07:49:02Z

Summary

New /careers landing page listing open roles pulled live from Sim's public Ashby job board (jobs.ashbyhq.com/sim), grouped by department with Team/Location filters.
Roles are fetched server-side at build/revalidate time (getAshbyJobs, mirrors the GitHub-stars pattern — cached, never throws) so every posting is in the crawlable HTML; the interactive board hydrates on top.
Filter state lives in the URL via nuqs (?team=/?location=), shareable and deep-linkable; the roles list stays server-rendered via a <Suspense> fallback.
Styled with landing tokens/patterns only (shared max-w-[1446px]/px-12 gutter, ChipSelect filters, TrustedBy reuse, single <h1> + sr-only GEO summary).
Footer "Careers" link now points to the internal /careers page; added /careers to the sitemap.

Type of Change

New feature

Testing

Tested manually against the live Ashby board; typecheck and biome clean.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-01T07:49:12Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 1, 2026 8:20am

cursor · 2026-07-01T07:49:13Z

PR Summary

Low Risk
Marketing/landing surface with defensive third-party fetch and URL validation; no auth, billing, or core app logic changes.

Overview
Adds a first-party /careers landing page with a mission hero and live open roles from Ashby’s public API via getAshbyJobs (hourly revalidate, Zod validation, http(s)-only apply URLs, graceful empty board on failure).

Roles are server-rendered for SEO; a client JobBoard adds Team/Location ChipSelect filters with shareable ?team= / ?location= state (nuqs). The server parses the same query for the Suspense fallback so deep links don’t flash an unfiltered list. Apply links still go to Ashby.

Footer Careers now points to /careers instead of the external Ashby board; /careers is included in the sitemap.

^{Reviewed by Cursor Bugbot for commit 575d9f9. Configure here.}

greptile-apps · 2026-07-01T07:51:24Z

Greptile Summary

This PR adds an internal careers page backed by Ashby's job board. The main changes are:

New /careers landing page with open roles grouped by department.
Server-side Ashby job fetching with validation and hourly revalidation.
URL-backed team and location filters for the job board.
Footer and sitemap updates for the new careers route.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/lib/ashby/jobs.ts	Adds the Ashby fetcher, response validation, per-posting skipping, URL validation, and normalized job shape.
apps/sim/app/(landing)/careers/careers.tsx	Adds the careers page layout and server-rendered job board fallback.
apps/sim/app/(landing)/careers/components/job-board/job-board.tsx	Adds client-side team and location filters backed by URL state.
apps/sim/app/(landing)/careers/components/job-board/job-groups.tsx	Adds grouped job rendering and de-duplicated metadata display.
apps/sim/app/(landing)/careers/search-params.ts	Defines shared careers filter query parsers and inactive-filter defaults.

_{Reviews (3): Last reviewed commit: "fix(careers): filter-aware empty state; ..." | Re-trigger Greptile}

waleedlatif1 · 2026-07-01T07:57:14Z

@greptile

waleedlatif1 · 2026-07-01T07:57:16Z

@cursor review

- validate jobUrl as http(s) only; drop postings with unsafe URLs - validate postings individually so one bad row can't empty the board - namespace the all-filter sentinel to avoid colliding with real values - dedupe the job metadata line (fixes duplicate React keys / Remote·Remote) - parse filters server-side so deep-linked views don't flash unfiltered

- JobGroups owns its empty copy via a filtersActive flag, so the server fallback and client board render identical, correct empty messaging (no-open-roles vs no-matching-filters) - convert remaining inline comments to TSDoc

waleedlatif1 · 2026-07-01T08:21:50Z

@greptile

waleedlatif1 · 2026-07-01T08:21:51Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 575d9f9. Configure here.}

#5320) A pre-existing permanent redirect /careers -> jobs.ashbyhq.com/sim shadowed the new first-party careers page (#5316), sending visitors straight to the Ashby board. Drop it so /careers serves the in-app page (which itself pulls the Ashby roles).

cursor Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/sim/app/(landing)/careers/components/job-board/job-groups.tsx

greptile-apps Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/sim/lib/ashby/jobs.ts

Comment thread apps/sim/lib/ashby/jobs.ts

Comment thread apps/sim/app/(landing)/careers/search-params.ts Outdated

Comment thread apps/sim/app/(landing)/careers/components/job-board/job-groups.tsx

Comment thread apps/sim/app/(landing)/careers/careers.tsx

vercel Bot temporarily deployed to Preview July 1, 2026 07:56 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/sim/app/(landing)/careers/components/job-board/job-board.tsx Outdated

Comment thread apps/sim/app/(landing)/careers/careers.tsx Outdated

vercel Bot temporarily deployed to Preview July 1, 2026 08:14 Inactive

waleedlatif1 added 3 commits July 1, 2026 01:18

feat(careers): careers page backed by the Ashby job board

fb53980

fix(careers): filter-aware empty state; drop inline comments

575d9f9

- JobGroups owns its empty copy via a filtersActive flag, so the server fallback and client board render identical, correct empty messaging (no-open-roles vs no-matching-filters) - convert remaining inline comments to TSDoc

waleedlatif1 force-pushed the worktree-careers-page branch from 4903dd3 to 575d9f9 Compare July 1, 2026 08:20

vercel Bot temporarily deployed to Preview July 1, 2026 08:20 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

waleedlatif1 merged commit 2393b72 into staging Jul 1, 2026
12 checks passed

waleedlatif1 deleted the worktree-careers-page branch July 1, 2026 08:25

This was referenced Jul 1, 2026

v0.7.19: newsletter, contact, careers #5318

Merged

fix(careers): remove /careers redirect so the in-app page is reachable #5320

Merged

Uh oh!

Conversation

waleedlatif1 commented Jul 1, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 1, 2026 •

edited

Loading

cursor Bot commented Jul 1, 2026 •

edited

Loading

greptile-apps Bot commented Jul 1, 2026 •

edited

Loading