Skip to content

fix(web): respect reduced motion in shared disclosures - #10258

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
saphid:fix/disclosure-reduced-motion-10255
Sep 6, 2026
Merged

fix(web): respect reduced motion in shared disclosures#10258
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
saphid:fix/disclosure-reduced-motion-10255

Conversation

@saphid

@saphid saphid commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Closes #10255.

What Changed

The shared Collapsible panel now skips its height transition when the user prefers reduced motion. It retains its existing 200 ms transition otherwise. The local shadcn/Base UI primitive, final height, trigger, and open state are preserved.

Why

The panel applied its height transition under both motion preferences. The global stylesheet has reduced-motion rules for other specific surfaces, but none covering this panel. This one-class correction also covers callers using the CollapsibleContent alias.

Addresses #10255.

UI Changes

Primary exercised Settings → Legacy features in the isolated running app, on base eee0557 and candidate 5710f47. Under normal motion both retained the height transition, focus stayed on the trigger, and open → close → reopen interrupted after 75 ms ended expanded with a 272.375 CSS-pixel panel. 1280×800 CSS viewport, dark theme.

Candidate normal-motion regression recording is supporting evidence that ordinary disclosure behavior is retained; it does not prove the reduced-motion fix. The attached preview has no reduced-motion emulation API and the host reports no-preference. Actual reduced-motion before/after GIFs and narrow-layout verification remain missing, so this PR remains draft. Caller-owned chevrons are unchanged.

Verification

  • vp fmt --check apps/web/src/components/ui/collapsible.tsx, vp lint apps/web/src/components/ui/collapsible.tsx, and git diff --check passed. Initial lint could not load its workspace plugin dependency; linking that existing dependency resolved it.
  • Installed Tailwind compiled the new variant to transition-property: none inside prefers-reduced-motion: reduce. Installed tailwind-merge preserved that variant with caller timing classes. Base UI 1.5.0 and its Collapsible export were verified against the lockfile and installed package.
  • The worker's borrowed-dependency typechecks failed on stale workspace declarations. Primary installed fresh dependencies in an isolated integration worktree and ran vp run --filter @t3tools/web typecheck: exit 0, first with this change alone, then with task-progress PR feat(web): animate task completion segments #10259 integrated.
  • Direct claude --model claude-opus-5 --effort high --permission-mode plan --tools Read --allowedTools Read -p … review exited 1 because OAuth expired and could not refresh. No Claude review occurred. Read-only standards baseline: 144fbf46af335d8d18a95c8d4b4f2e9e0207fa2e.

Web/Electron shared UI only; native clients are unchanged. Normal-motion focus retention, interruption, final height and computed transition were observed. Keyboard-only expansion and runtime reduced-motion remain unverified. This draft is not review-ready.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Implemented and assessed by GPT-6 Astra medium in Codex. No other model supplied review findings.

Maintainer verification, September 6

This supersedes the missing browser-proof notes above. I independently reviewed the one-file change at 5710f475 and exercised the actual Settings → Legacy features control in isolated Chromium with synthetic data and all real providers disabled.

With reduced motion enabled, the baseline emitted height transitions lasting 200 ms and showed intermediate heights. This candidate emits no panel transition events and computes transition-property: none. Mouse expansion and keyboard close/reopen preserve focus on the trigger and finish at the same 272.375 CSS-pixel height. Normal-motion keyboard reversal still emits transition and cancellation events and ends expanded. At 390×844, reduced-motion keyboard close/reopen also has no height transition; page width remains 390 and panel content width equals its 338-pixel box. No settings, provider turns or live user database were changed.

Matched before/after recordings, six seconds each, crop the same actual 1280×2600 capture around the disclosure. Playback speed is unchanged. The stills intentionally show the same settled state; the recordings and transition measurements demonstrate the fix.

Before, reduced motion still animates:

Before recording

Before: expanded Legacy features after the unwanted transition

After, reduced motion changes state immediately:

After recording

After: identical expanded Legacy features without a height transition

The retained host is main bd16b86d with separately reviewed usage overlays. I verified the actually served disclosure module's source map against exact baseline and candidate bytes. Disclosure and General settings sources are unchanged through ab67795d, committed 03:54:49 UTC. This is not an entirely latest-main app run or a native Electron OS-preference test. The change is shared web/Electron CSS only; native mobile, providers, connection modes and wire contracts are untouched.

Current-head checks before marking ready: 15 successful, four skipped, no findings or pending jobs. Exact-file lint and formatting passed. No repo-wide local suite was run. Marking ready requests the configured reviewers; it is not a merge claim.

Independent review and browser verification by GPT 6 Astra via Codex in T3 Code. The author's implementation and attribution are preserved.

Note

Add motion-reduce:transition-none to CollapsiblePanel

Users who request reduced motion at the OS level no longer get the panel's height transition animation. Other users keep the existing transition behavior.

Macroscope summarized 5710f47.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 6, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review September 6, 2026 04:18
@macroscopeapp

macroscopeapp Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5710f47

Macroscope's review found this PR approvable — This is a focused one-file accessibility fix that disables the shared disclosure height animation only for users who prefer reduced motion, while preserving existing behavior otherwise. It introduces no API, schema, deployment, security, billing, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 84aebb7 into pingdotgg:main Sep 6, 2026
28 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 6, 2026
## What's Changed
* fix(web): keep timestamp tooltip dates in English by @Lucenx9 in pingdotgg/t3code#10256
* fix(web): let authorized clients scrolling reach settings by @flamboh in pingdotgg/t3code#10080
* fix(web): remember usage page selection by @extoci in pingdotgg/t3code#10189
* fix(server): keep the Antigravity Google sign-in across server restarts by @t3dotgg in pingdotgg/t3code#10244
* fix(antigravity): load user skills from ~/.gemini for every project by @t3dotgg in pingdotgg/t3code#10257
* fix(web): respect reduced motion in shared disclosures by @saphid in pingdotgg/t3code#10258
* feat(marketing): add a Windows 95 landing page by @t3dotgg in pingdotgg/t3code#10286
* refactor(web): remove unused runtime wrappers and exports by @juliusmarminge in pingdotgg/t3code#10225
* refactor(web): keep feature component helpers private by @juliusmarminge in pingdotgg/t3code#10226
* refactor(web): keep app utilities private and remove dead helpers by @juliusmarminge in pingdotgg/t3code#10227
* ci: enforce unused runtime exports in the web app by @juliusmarminge in pingdotgg/t3code#10228
* test(desktop): cover Clerk setup through the service by @juliusmarminge in pingdotgg/t3code#10284
* test(desktop): cover WSL hashes through runtime resolution by @juliusmarminge in pingdotgg/t3code#10285
* test(desktop): cover password store through startup by @juliusmarminge in pingdotgg/t3code#10287
* test(desktop): cover WSL paths through public behavior by @juliusmarminge in pingdotgg/t3code#10289
* test(desktop): exercise WSL cache safety through public scripts by @juliusmarminge in pingdotgg/t3code#10301
* test(web): cover file classification through diff ordering by @juliusmarminge in pingdotgg/t3code#10304
* test(web): focus command palette tests on search behavior by @juliusmarminge in pingdotgg/t3code#10302
* fix(web): add project settings to legacy sidebar project menu by @hwanseoc in pingdotgg/t3code#10021
* test(web): keep Markdown gutter styling private by @juliusmarminge in pingdotgg/t3code#10306
* feat(settings): add shared project defaults and scoped overrides by @maria-rcks in pingdotgg/t3code#9754
* feat(connections): balance new threads across connected machines by @maria-rcks in pingdotgg/t3code#9895
* test(web): keep settings viewport comparison private by @juliusmarminge in pingdotgg/t3code#10307
* fix(web): prevent file tree search focus ring clipping by @GuilhermeVieiraDev in pingdotgg/t3code#10175
* fix(mobile): stop the work log flickering during subagent runs and failing calls by @juliusmarminge in pingdotgg/t3code#10273
* fix(mobile): save linked media from chat by @juliusmarminge in pingdotgg/t3code#10271
* feat(markdown): show the GitHub mark for github.com links by @juliusmarminge in pingdotgg/t3code#10324
* fix(marketing): show a real preview card when t3.codes is shared by @t3dotgg in pingdotgg/t3code#10305


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1292...v0.0.39-nightly.20260906.1293

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1293
aorwall added a commit to aorwall/t3code that referenced this pull request Sep 7, 2026
Merges 141 upstream commits (`b438447f6..8b2838e`) into the fork,
following the
`fork-upstream-merge` skill. Landed as a merge commit; conflicts
resolved by the
path-policy verdicts in `docs/fork/inventory.json`.

## Merge shape

563 files landed (`git diff --stat HEAD^1 HEAD`) against 563 in the
upstream
range, so no upstream work was dropped. Fork delta 720 files.

## Conflicts

14 files, resolved by concern. The merge commit message names each. Two
are worth
carrying forward:

- Upstream extracted the project action rows into
`ProjectActionsList.tsx`. The
fork's Edit gate now rides an `editable` prop that defaults to
upstream's
  always-editable behavior, so the gate survives the next extraction.
- Upstream moved the `agent-browser-access` setting onto its new
`/settings/projects` page. `settingsSearch.ts` points that item there
and drops
  a fork delta.

## Two things a clean merge did not show

**Upstream can delete an export the fork still imports.** pingdotgg#10225 removed
`ClientTracingLive` as unused. `apps/web/src/lib/runtime.ts` still
installs it,
and neither file conflicted, so the typecheck failed four ways on a
merge git
called clean. Restored with a `// Fork:` comment naming the consumer.

**A green test step can hide a suite that never finished.** `vp run -r
test`
kills the packages still running when one of them fails. A
`@t3tools/desktop`
failure truncated `apps/web` and `@t3tools/mobile` after each had
reported
hundreds of passing files, and `verify.mjs` counted any package with
labeled
output as tested. Four failing web tests went unreported. The check now
keys on
the closing `Test Files` line and runs every unfinished package alone.

## Unsupported methods

`unsupported-methods.mjs` reports 0 ADD, 0 DROP, 2 KEEP, against 61
dispatched
backend methods and 131 contract methods.

Getting there took a fix. The backend moved its dispatch from
`crates/t3code/src/lib.rs` to `crates/t3code/src/rpc/dispatch.rs`, where
every
arm is a one-line call into a handler below the match. The script read
the old
path and reported zero dispatched methods, then read the new one and
called
`vcs.switchRef` a DROP, because the `unsupported_exit` that refuses it
had moved
out of the arm. It now tries both paths and follows an arm two calls
deep.

Contract changes: `provider.consumeResetCredit` and
`server.getHostResources`
gained `UnsupportedMethodError`; `server.getUsageSummary` lost it, which
closes
the item the previous merge left open.

## Feature classification

**Usable as-is** — client-only, nothing new on the wire. Sidebar drag
across
sections with destination cues and a named drop action (pingdotgg#9731, pingdotgg#9750,
pingdotgg#10378,
pingdotgg#10453, pingdotgg#10464). Composer behavior: a multiline draft survives timeline
scrolling (pingdotgg#10444), the composer stops collapsing on blur (pingdotgg#10437) and
regains
focus when you tab back (pingdotgg#10463). Panel and preview chrome: resize the
floating
preview from any edge (pingdotgg#10467), toolbar controls stay anchored (pingdotgg#10478),
the
stuck resize cursor clears (pingdotgg#10461), the browser hides as the right
panel closes
(pingdotgg#10385), manual panel choices hold during a turn (pingdotgg#10113). Settings and
accessibility polish (pingdotgg#10177, pingdotgg#10262, pingdotgg#10415, pingdotgg#10258, pingdotgg#10124, pingdotgg#10125,
pingdotgg#10127,
pingdotgg#10128, pingdotgg#10175). Performance (pingdotgg#10413, pingdotgg#10190, pingdotgg#10118). Plus the GitHub
mark on
`github.com` links (pingdotgg#10324), the Tux icon for WSL (pingdotgg#8511), a remembered
usage
page selection (pingdotgg#10189), project settings in the legacy sidebar menu
(pingdotgg#10021),
and text-only preview snapshots (pingdotgg#10232).

**Unsupported in Moatless** — resolves to a refusal, or falls through to
its own
empty state. Each is recorded in `docs/fork/gaps.md`:

- Reset credits through the hub and CLIProxyAPI (pingdotgg#10462, pingdotgg#10395,
pingdotgg#10308).
`provider.consumeResetCredit`, new union entry. `UsageLimits.tsx`
catches the
  refusal and shows "Could not use the reset credit."
- Balancing new threads across connected machines (pingdotgg#9895, pingdotgg#10433,
pingdotgg#10407).
`server.getHostResources`, new union entry. Nothing polls until a user
picks
automatic routing, and the composer then reads "Auto balance
unavailable."
- Onboarding: import grouped by repository (pingdotgg#10493), the shared
multi-computer
  wizard (pingdotgg#10465), agent install without Node or npm (pingdotgg#10402). All ride
  `agentSessions.scan` and `.import`, an existing gap.
- Shared project defaults and scoped overrides (pingdotgg#9754). The page reads,
and every
  write goes through `server.updateSettings`, which the backend does not
  dispatch.
- Two new `orchestration.dispatchCommand` types: `thread.active.reorder`
(pingdotgg#9729)
and `thread.user-input.dismiss` (pingdotgg#10431). Both are ordinary controls, a
sidebar
drag and a Dismiss button, and a dispatched command cannot be refused
per type.
That is the standing _A command cannot be refused_ gap, now 26 members
wide.

**Backend behavior to consider reproducing in Moatless** — upstream
server fixes
whose behavior the fork's client assumes:

- Invalid script IDs no longer crash threads (pingdotgg#10019). The fork ships
project
  scripts, so this one is worth reading first.
- Settlement: settle inactive threads without a PR lookup (pingdotgg#10103), skip
disabled
settlement lookups (pingdotgg#10424), settle threads with unanswered async
questions
  (pingdotgg#10400).
- Interrupted threads stay resumable after a restart (pingdotgg#10421).
- Completed requests stay closed across clients (pingdotgg#10123).
- Placeholder branches are followed after a checkout updates (pingdotgg#10441).
- A thread's PR links without an open client (pingdotgg#10101), and checkpoints
are
  captured before a PR status refresh (pingdotgg#10347).
- Adapters declare their own context compaction (pingdotgg#10112).
- Transcripts with oversized tool records import (pingdotgg#10430), and git
status scans
  are skipped while the index is locked (pingdotgg#9845).
- Usage limits pool per provider across accounts and environments
(pingdotgg#10300). The
client renders what `server.getUsageSummary` returns, so this shows
something
  only if the Moatless payload carries per-account limits.

Mobile, marketing, desktop, provider adapters and release tooling are
not this
fork's surface and are not classified.

## Also fixed here, and not upstream's doing

- Three `browser-*` search items still routed to
`/settings/integrations`, which
the fork owns for its Moatless administration page. A non-administrator
who
  searched for them was redirected away from the result.
- `moatless/listSearch.ts` carried no fork-only declaration.
- `pnpm fmt:check` failed on 294 files, 293 of them orval output. The
generator
  now formats what it writes through an `afterAllFilesWrite` hook.
- `@t3tools/moatless-api` exported `./generated`, a barrel that is never
checked
  in.

## Verification

`inventory-check.mjs` clean. `verify.mjs` green on seven checks:
duplicate-adds,
tripwires, resolution-check, unsupported-methods, `fmt:check` (3876
files),
`lint` and `typecheck`.

`test` is red on one package, and it is the machine.
`@t3tools/desktop`'s
`bundled libsecret helper` shells out to `pkg-config` for `libsecret-1`,
which
this sandbox does not have; it fails the same way when retried alone.
Everything
else passes: `apps/web` 369 files, `t3` 291, `@t3tools/mobile` 149,
`t3code-relay` 27, `@t3tools/client-runtime` 71, plus the smaller
packages.

`spec:check` cannot run in a sandbox: it needs a sibling `moatless`
checkout or a
deployment URL and has neither.

Written by Claude Opus 5 in Claude Code.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---
Moatless task:
https://moatless.soaplabstest.com/tasks/8d348ecf-f9cb-4e65-b96b-6c1054a8ed33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify reduced-motion behavior of shared disclosures

2 participants