fix(cuda.core): preserve DLPack C exchange errors - #2939
Merged
Merged
Conversation
Signed-off-by: Rui Luo <ruluo@nvidia.com>
github-actions
Bot
added
the
cuda.core
Contributor
|
Contributor
|
Thanks for the fix, and I confirmed it works. I think we can avoid adjusting the exception state by hand through CPython calls if we declare the Cython entry points |
Declare the exchange API callbacks and their typedefs `except -1`, the contract dlpack.h documents, and raise instead of setting the error indicator by hand. KeyboardInterrupt and other BaseExceptions now also reach the consumer as -1 with the exception set. Co-authored-by: Andy Jost <ajost@nvidia.com> Signed-off-by: Rui Luo <ruluo@nvidia.com>
Contributor
Author
|
Thanks @Andy-Jost for the review, that's cleaner. I've taken your change in 3e7c139 (with you as co-author), and the existing tests pass unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The DLPack C exchange API requires export/import callbacks to return
-1with a Python exception set
(dlpack.h;
BufferErrorwhen the data cannot be described).StridedMemoryViewreturned-1without restoring the exception.This PR restores the exception with
PyErr_SetObjectbefore returning-1,adds regression tests for both export entry points and unsupported-
device import, and add a release note.