Skip to content

[doc-only] Add release notes about removed reserved members - #2972

Merged
mdboom merged 4 commits into
NVIDIA:mainfrom
mdboom:reserved-release-notes
Sep 30, 2026
Merged

[doc-only] Add release notes about removed reserved members#2972
mdboom merged 4 commits into
NVIDIA:mainfrom
mdboom:reserved-release-notes

Conversation

@mdboom

@mdboom mdboom commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Addresses this intentional change to not expose these private/internal-use-only members.

@github-actions github-actions Bot added the cuda.bindings Everything related to the cuda.bindings module label Sep 30, 2026
@mdboom mdboom self-assigned this Sep 30, 2026
@mdboom mdboom added the documentation Improvements or additions to documentation label Sep 30, 2026
@mdboom mdboom added this to the cuda.bindings 13.5.0 & 12.9.10 milestone Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang mentioned this pull request Sep 30, 2026
Merged
@leofang

leofang commented Sep 30, 2026

Copy link
Copy Markdown
Member

I think we should also offer a snippet in both the rel-note and tips/tricks to teach users how to wrap a foreign bag of bytes.

We should also make it clear somewhere else (outside of the rel-note) that we zero-initialize all structs so initialization is not a problem for binding users.

leofang
leofang approved these changes Sep 30, 2026
View reviewed changes

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about our final plan is w.r.t. IPC structs. I'll let you handle it. Approving.

@mdboom
mdboom requested a review from leofang September 30, 2026 19:26
@mdboom

mdboom commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Not sure about our final plan is w.r.t. IPC structs. I'll let you handle it. Approving.

After some back and forth, I arrived at just documenting how to set the bytes directly. It's a stop gap until _v2 ships and more users just use cuda.core directly.

leofang
leofang approved these changes Sep 30, 2026
View reviewed changes
Comment thread cuda_bindings/docs/source/release/13.4.0-notes.rst

This does it is no longer to get or set these bytes directly. To create a
wrapped struct from a buffer (for example, for pickling), see
:ref:`tips-setting-raw-struct-bytes`.

@leofang leofang Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Should we also copy this note to 13.4.1/13.4.2?

@mdboom
mdboom enabled auto-merge (squash) September 30, 2026 21:19
@mdboom
mdboom merged commit f58b507 into NVIDIA:main Sep 30, 2026
33 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 1, 2026
cuda-python-bot
Clean up PR preview folders for 10 closed/merged PRs
4650b23 
Removed preview folders for the following PRs:
- PR #2939
- PR #2953
- PR #2962
- PR #2966
- PR #2968
- PR #2969
- PR #2972
- PR #2974
- PR #2976
- PR #2977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofang leofang leofang approved these changes

Assignees

@mdboom mdboom

Labels

cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation

Projects

None yet

Milestone

cuda.bindings 13.5.0 & 12.9.10

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom @leofang