Removed server-side use of --status in gh run list - #2976
Merged
Merged
Conversation
Removed the use of --status, which https://github.com/orgs/community/discussions/24626 is tracking as a stale server side data problem. Gemini recommends removal of server-side --status and replacement with client side jq.
Contributor
|
Member
|
Seems like a good improvement but we should probably keep #2975 open for a few more days just to monitor if the situation improves? |
Contributor
Author
|
@leofang changed. the description to 'refs' instead of 'closes'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2975
Description
Removed the use of --status in gh run list, which https://github.com/orgs/community/discussions/24626 is tracking as a stale server side data problem.
Gemini recommends removal of server-side --status and replacement with client side jq.
NB the first removed use of --status success has just below it a completed == success check. I'm hesitant to add another status success check because there is some confusion about the string value of .status.
Checklist