Skip to content

build: keep sccache prefix when CUDA_PYTHON_TOOLCHAIN selects a compiler - #2969

Merged
juenglin merged 1 commit into
NVIDIA:mainfrom
juenglin:sccache-with-toolchain
Sep 30, 2026
Merged

build: keep sccache prefix when CUDA_PYTHON_TOOLCHAIN selects a compiler#2969
juenglin merged 1 commit into
NVIDIA:mainfrom
juenglin:sccache-with-toolchain

Conversation

@juenglin

@juenglin juenglin commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Follow-up to #2903. An explicit CUDA_PYTHON_TOOLCHAIN was replacing CI's CC="sccache cc" / CXX="sccache c++" with a bare compiler, so llvm/gnu builds would skip sccache.

_with_sccache keeps a leading sccache token (including absolute paths such as /host/.../sccache used by cibuildwheel) and only swaps the compiler: CC="sccache cc" + llvm becomes CC="sccache clang". The same prefix is applied to CXX; LDSHARED is {CXX} -shared. The default path (unset CUDA_PYTHON_TOOLCHAIN) still does not touch CC/CXX.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Sep 30, 2026
@juenglin

juenglin commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4dcef12

@juenglin juenglin self-assigned this Sep 30, 2026
@juenglin juenglin added the CI/CD CI/CD infrastructure label Sep 30, 2026
@juenglin juenglin added this to the cuda.bindings next milestone Sep 30, 2026
@juenglin
juenglin requested a review from rwgk September 30, 2026 02:23
@juenglin
juenglin marked this pull request as ready for review September 30, 2026 02:25
@github-actions

github-actions Bot commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

rwgk
rwgk reviewed Sep 30, 2026
View reviewed changes
Comment thread cuda_bindings/build_hooks.py
Comment thread cuda_bindings/build_hooks.py
@juenglin
juenglin requested a review from rwgk September 30, 2026 18:05
@juenglin
juenglin merged commit ba794ef into NVIDIA:main Sep 30, 2026
331 of 338 checks passed
juenglin added a commit to juenglin/cuda-python that referenced this pull request Sep 30, 2026
@juenglin
Merge branch 'main' into build-hooks-refactor
83555f7 
Keep LDCXXSHARED sysconfig extras; NVIDIA#2969 sccache prefix is already in this branch.
@juenglin juenglin mentioned this pull request Sep 30, 2026
Merged
2 tasks done
github-actions Bot pushed a commit that referenced this pull request Oct 1, 2026
cuda-python-bot
Clean up PR preview folders for 10 closed/merged PRs
4650b23 
Removed preview folders for the following PRs:
- PR #2939
- PR #2953
- PR #2962
- PR #2966
- PR #2968
- PR #2969
- PR #2972
- PR #2974
- PR #2976
- PR #2977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

Assignees

@juenglin juenglin

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module

Projects

None yet

Milestone

cuda.bindings next

Development

Successfully merging this pull request may close these issues.

2 participants

@juenglin @rwgk