ci(docs): keep release deploys from overwriting the shared version switcher - #2962
Merged
Andy-Jost merged 1 commit intoSep 30, 2026
Merged
Conversation
…itcher The "Choose Version" dropdown on every cuda.core docs page is driven by one file at the docs root, cuda-core/nv-versions.json, which each page fetches by absolute URL. Every docs deploy copies its own checkout's copy over that root file. Deploys from main keep it current; a release built from a release branch overwrote it with that branch's older list, which hid every version released from main after the branch point until the next main deploy restored it (seen with cuda-core-v1.2.1, NVIDIA#2935/NVIDIA#2944). Delete the switcher files from the release build output next to the existing removal of latest/. The deploy action runs with clean: false, so the root copy on gh-pages is left untouched and main alone owns it. The new version's entry is added on main as part of release prep. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Andy-Jost
added
P1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Choose Version" dropdown on every cuda.core docs page is driven by one file at the docs root,
cuda-core/nv-versions.json, which each page fetches by absolute URL (conf.py,switcher.json_url). Every docs deploy copies its own checkout's copy over that root file, and the deploy action runs withclean: false.Deploys from
mainkeep the file current. A release built from a release branch overwrote it with that branch's older list, which hides every version released frommainafter the branch point until the nextmaindeploy restores it. We hit this with cuda-core-v1.2.1 (#2935, #2944, #2946).This change deletes
nv-versions.jsonand the legacyversions.jsonfrom the release build output, next to the existing removal oflatest/. Release deploys then leave the root copy alone andmainalone owns the dropdown. Two lines, one per build step.Process consequence
The new version's entry in
cuda_core/docs/nv-versions.jsonis added onmainas part of release prep, never on a release branch. That is what already happens for releases tagged onmain, where the prep PR merges before the tag.Not changed
The root
objects.invis also copied from the version being built and is still overwritten by release deploys. That seems desirable, since intersphinx consumers then resolve against the newest release, so it is left as is.🤖 Generated with Claude Code