[pull] trunk from WordPress:trunk - #1982
Open
pull[bot] wants to merge 2766 commits into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: At least one To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
force-pushed
the
trunk
branch
2 times, most recently
from
July 6, 2026 03:10
3af2d27 to
64ede28
Compare
…PHPStan. PHPStan infers the `WP_HTML_Tag_Processor::parse_next_tag()` method as pure, so the `STATE_READY` value narrowed onto `$parser_state` before the call survives across it, even though the method reassigns that property throughout its body. Every state comparison that follows in the `base_class_next_token()` method is then decided at analysis time rather than at runtime: both `&&` operands resolve to `true`, the early `return true` is treated as unconditional, and the remainder of the method is analyzed as unreachable. This in turn leaves `skip_rawtext()` and `skip_script_data()` reported as uncalled and `$skip_newline_at` as never assigned an `int`. Adding `@phpstan-impure`, the annotation PHPStan's own tip recommends, resolves ten baselined errors across six identifiers; `next_tag()` in the same class already carries it. This empties the `booleanAnd.alwaysTrue` and `property.unusedType` baselines, so both files are removed along with their `includes` entries in `phpstan.neon.dist`. Developed in #13057. Follow-up to r61934, r63023. Props tstokes8040. See #65817. git-svn-id: https://develop.svn.wordpress.org/trunk@63301 602fd350-edb4-49c9-b593-d223f7449a82
Two test cases still used the legacy PHPUnit stub API. This replaces them with the modern shorthands, which are what the rest of the suite already uses.
`tests/phpunit/tests/pomo/pluralForms.php`
{{{
// Before
->will( $this->returnValue( 1 ) );
// After
->willReturn( 1 );
}}}
`tests/phpunit/tests/rest-api/rest-server.php`
{{{
// Before
->with( $this->equalTo( 400 ) );
// After
->with( 400 );
}}}
**Why this is safe**
`willReturn()` is a direct shorthand for `will( $this->returnValue() )` and has been available since PHPUnit 5.4. The test suite enforces a minimum of PHPUnit 5.7.21 in `tests/phpunit/includes/bootstrap.php`, so it is safe on every supported version, and the suite already contains 83 `willReturn()` calls.
`with()` wraps any non-`Constraint` argument in an `equalTo()` constraint itself, so passing `400` directly is identical in behaviour. The suite already has 43 `with()` calls that pass values directly.
Note on the first change: that line was originally written as `willReturn( 1 )` and switched to the long form in r41725 because of the PHPUnit versions supported back then. That constraint no longer applies, so this effectively reverts an obsolete workaround.
Developed in #13052.
Follow-up to r34928, r41725.
Props Soean.
See #65819.
git-svn-id: https://develop.svn.wordpress.org/trunk@63303 602fd350-edb4-49c9-b593-d223f7449a82
The header backgrounds now ship with WordPress as SVG files instead of being fetched from the CDN, the feature images have been recompressed, and those below the fold are lazy loaded. Follow-up to [63182]. Props iamchitti, joedolson, markoserb, mukesh27, peterwilsoncc, wildworks. Fixes #65854. git-svn-id: https://develop.svn.wordpress.org/trunk@63304 602fd350-edb4-49c9-b593-d223f7449a82
Reverts the focus and hover style changes in the admin toolbar. Reverts [63190], [63009], and [63188], restoring the appearance in WordPress 7.0. Props fushar, wildworks, ravichudasama01, afercia, joen, keoshi, cbusquets1989, annezazu. Fixes #65849. See #65445. git-svn-id: https://develop.svn.wordpress.org/trunk@63306 602fd350-edb4-49c9-b593-d223f7449a82
Fixes the behavior of `url_to_postid()`, which treated a `www.` string anywhere in the URL as optional, breaking some URLs. Anchor the string so that is only considered optional when at the beginning of a URL string. Follow up to [63207]. Props youknowriad, johnbillion, wildworks, irozum, joedolson. Fixes #65016. git-svn-id: https://develop.svn.wordpress.org/trunk@63307 602fd350-edb4-49c9-b593-d223f7449a82
Add gzip directives to the nginx config template used by the local Docker environment so that HTML, JavaScript, CSS, JSON, XML, and SVG responses can be served compressed, matching normal production behavior. Without compression, frontend performance analysis against the local environment is not representative of a real user's experience. Compression is controlled by a new `LOCAL_NGINX_COMPRESSION` option, and it defaults to `off` so that it is opt-in. Since this changes `docker-compose.yml` in addition to the nginx template, existing checkouts need to recreate the web server container to pick up the change. Developed in #12529. Follow-up to r45745, r45783. Props westonruter, jblz. Fixes #65634. git-svn-id: https://develop.svn.wordpress.org/trunk@63308 602fd350-edb4-49c9-b593-d223f7449a82
When an `npx` command is run, the specified package will be downloaded and installed when it does not exist locally. This will also install all of the package’s direct and transitive dependencies, and any installation scripts present for every installed package are run. This is potentially dangerous because a compromised package would be able to run code on a local machine or within a GitHub Actions workflow runner. This replaces every `npx` call with `npm exec --no`, which runs an installed binary only and will fail when the package is missing. Additionally, `update-browserslist-db` is now defined as a direct `devDependency`. Props adrianmoldovanwp, desrosj, lancewillett, johnbillion. Fixes #65864. git-svn-id: https://develop.svn.wordpress.org/trunk@63309 602fd350-edb4-49c9-b593-d223f7449a82
…w runs. GitHub Actions expressions and contexts do not currently expose the details about a workflow run necessary to determine whether a workflow has timed out. Instead, all timed out runs are considered `cancelled`. However, the REST API does return a `timed_out` conclusion in this scenario. This creates a new job for the `timed_out` conlclusion and adjusts the logic for cancelled Slack notifications to provide more useful notifications. Props lancewillett. See #65845. git-svn-id: https://develop.svn.wordpress.org/trunk@63310 602fd350-edb4-49c9-b593-d223f7449a82
Replaces eight generic `assertTrue( is_callable() )` assertions with PHPUnit's dedicated `assertIsCallable()` assertion. Developed in #13017. Follow-up to r50996, r61760. Props raulsalvat, Soean. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@63311 602fd350-edb4-49c9-b593-d223f7449a82
`validate_file()` runs `wp_normalize_path()` before testing for a drive letter at offset 1. That call folds backslashes to forward slashes, but its slash-collapsing regex deliberately spares a leading `//` to allow for network shares. UNC paths such as `//server/share`, and the device namespaces `//./` and `//?/`, therefore arrived with no colon in the second byte and returned `0` rather than `2`. The docblock described a return value of `2` as meaning the path contains a Windows drive path, which reads as a guarantee that Windows absolute paths are screened. Most forms were not. Anchoring a second test to the start of the string closes that gap. Stream wrappers stay at `0` by two separate mechanisms: a registered wrapper keeps its `://` through the scheme split, placing those slashes past the second byte, while an unregistered scheme has its `//` collapsed. Code `2` now fires on strictly more inputs and never fewer, so no existing rejection becomes an acceptance. Absolute POSIX paths such as `/etc/passwd` continue to return `0`; screening those would be a larger change affecting plugins that pass absolute template paths. Paths beginning with two successive slashes are now rejected regardless of platform, which includes the implementation-defined POSIX doubled-slash form, consistent with the assumption `wp_normalize_path()` already makes about a leading `//`. Props zieladam, SergeyBiryukov. Fixes #51368. git-svn-id: https://develop.svn.wordpress.org/trunk@63312 602fd350-edb4-49c9-b593-d223f7449a82
This temporarily marks the `SLACK_GHA_TIMEOUT_WEBHOOK` secret as optional until [63310] can be backported to older branches to avoid workflow failures. Follow-up to [63310]. See #65845. git-svn-id: https://develop.svn.wordpress.org/trunk@63313 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a couple of functions with return-type problems. One is resolved by adding the missing `void` type, while the other is resolved by updating the function to conform to the existing `string` return type contract, a likely oversight in the original commit. This change was part of Contributor Day at WordCamp US 2026. Developed in: #13081 Discussed in: https://core.trac.wordpress.org/ticket/65817 Props dmsnell, nomadmystic. See #65817. git-svn-id: https://develop.svn.wordpress.org/trunk@63314 602fd350-edb4-49c9-b593-d223f7449a82
…quests. This workflow has not proven to be as useful as originally hoped, so it's being removed to reduce maintenance burden. All workflows that run the build script already fail if they result in untracked changes. Developed in #13087 Props desrosj See #65845 git-svn-id: https://develop.svn.wordpress.org/trunk@63315 602fd350-edb4-49c9-b593-d223f7449a82
…locks. The [https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/ PHP inline documentation standards] place `@return` immediately after the last `@param` tag, with no blank line between them: {{{ /** * Summary. * * @SInCE x.x.x * * @PARAM string $var Description. * @return string Description. */ }}} This corrects 44 docblocks across 33 files in `src/wp-includes` that used a line break between the two tags. Developed in #13063. Props mukesh27, dhruvang21. See #65818, #65860. git-svn-id: https://develop.svn.wordpress.org/trunk@63320 602fd350-edb4-49c9-b593-d223f7449a82
…ry` properties. Developed in #13126. Follow-up to r10584, r32990, r57734. Props pedromendonca, mukesh27, dhruvang21. Fixes #65901. git-svn-id: https://develop.svn.wordpress.org/trunk@63323 602fd350-edb4-49c9-b593-d223f7449a82
This sets 7.1 as the most recent branch of WordPress in the upgrade testing workflows. See #65845, #65844. git-svn-id: https://develop.svn.wordpress.org/trunk@63327 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to r63314. See #65817. git-svn-id: https://develop.svn.wordpress.org/trunk@63328 602fd350-edb4-49c9-b593-d223f7449a82
Updates the "Welcome to WordPress X.X" heading to use a placeholder for the version number to ease l10n efforts with a reusable string across each version of WordPress. Props nekojonez, khokansardar, mukesh27, SergeyBiryukov. Fixes #65895. git-svn-id: https://develop.svn.wordpress.org/trunk@63329 602fd350-edb4-49c9-b593-d223f7449a82
Block Supports: guard against non-string attribute values to avoid fatal errors This commit guards layout block supports values with type checks before render. The reason is that `block.json` / `theme.json` types aren't enforced at render time, so wrong-typed values can reach strict PHP checks and cause fatals. The cause is mainly hand-edited, imported, or AI-generated serialized content, not the block editor. Developed in: #12674 Props im3dabasia1, ramonopoly, westonruter. Fixes #65774. git-svn-id: https://develop.svn.wordpress.org/trunk@63330 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a bug where `get_tag_regex()` may match multiple tags of the same type in the content. Also, adds tests. Developed in #13037 Props pbearne, kopepasah, gunjanjaswal, debarghyabanerjee, mukesh27, desrosj, ocean90, nacin, chriscct7, r1k0, afercia. Fixes 26674. Fixes 59791. git-svn-id: https://develop.svn.wordpress.org/trunk@63331 602fd350-edb4-49c9-b593-d223f7449a82
…tons. In the Customizer > Widgets panel, the visual order of the 'Reorder' and 'Add a Widget' buttons didn't match the DOM order. For accessibility, the visual order and DOM order must match when they impact tab sequence, interaction, and meaning. Also, improves the alignment of the buttons. Developed in #13135 Props khokansardar, joedolson, afercia. Fixes #65902. git-svn-id: https://develop.svn.wordpress.org/trunk@63332 602fd350-edb4-49c9-b593-d223f7449a82
…locks. The [https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/ PHP inline documentation standards] place `@return` immediately after the last `@param` tag, with no blank line between them: {{{ /** * Summary. * * @PARAM string $var Description. * @return string Description. */ }}} This corrects 65 docblocks across 29 files in the PHPUnit test suite. Developed in #13119. Follow-up to [63320]. Props mukesh27. See #65818, #65860. git-svn-id: https://develop.svn.wordpress.org/trunk@63333 602fd350-edb4-49c9-b593-d223f7449a82
To improve performance, r62408 replaced `spl_object_hash()` with `spl_object_id()` when building the array keys for `WP_Hook::$callbacks` and for `WP_Widget_Factory::$widgets`. Even when the `spl_object_id()` return value is cast to a string to preserve the previous string array keys, PHP automatically converts such numeric strings to `int` when assigning the array key. This resulted in a back-compat breakage for plugins that expected to use the array keys in string functions, including possible fatal errors when using `strict_types`. To preserve the previous string key behavior, any array keys using `spl_object_id()` are now prefixed with a string to prevent coercion to `int`. This not only fixes the expected array key types when iterating over these arrays, but it also fixes the return type for `WP_Widget_Factory::get_widget_key()` so it actually returns a string. In addition to the added tests, the `non-decimal-int-string` type in PHPStan is leveraged instead of a plain `string` to prevent this regression from returning. Developed in #13209. Follow-up to r62408, r62733. Props westonruter, dugi-digitaly, sergeybiryukov. See #58291. Fixes #65919. git-svn-id: https://develop.svn.wordpress.org/trunk@63334 602fd350-edb4-49c9-b593-d223f7449a82
…l buttons. Amends [63332]. Allows buttons to wrap when longer translations may cause them to overflow the panel width. Props sabernhardt, afercia. Fixes #65902. git-svn-id: https://develop.svn.wordpress.org/trunk@63335 602fd350-edb4-49c9-b593-d223f7449a82
…an array. Reading the first key of an array through `array_keys()` allocates a full array of every key just to keep one entry and discard the rest. `array_key_first()` reads the first bucket directly. Follow-up to r63297 / #65773, which is scoped to the two nested `current( array_keys( $array ) )` call sites. This commit covers a second shape of the same idea, which that ticket does not include: the key array is assigned to a variable first, then read on the next line. {{{ $keys = array_keys( $wp_registered_sidebars ); $sidebar = reset( $keys ); }}} {{{ $sidebar = array_key_first( $wp_registered_sidebars ); }}} 13 occurrences across 11 files, in two shapes — `reset( $keys )` and `$keys[0]`. In every case the intermediate variable existed only to carry the key array to the next line and is never read again afterwards. **One change that goes further** In `spawn_cron()` and `_wp_cron()` the surrounding check is dropped too: {{{ $keys = array_keys( $crons ); if ( isset( $keys[0] ) && $keys[0] > $gmt_time ) { }}} {{{ if ( array_key_first( $crons ) > $gmt_time ) { }}} Both functions return early a few lines above when `$crons` is empty, so `isset( $keys[0] )` can never be false there. **Behavior notes** - On an empty array `reset()` returns `false` while `array_key_first()` returns `null`. None of the touched call sites compares the result with `===`, and most sit behind an `empty()` guard. - Where the old code used `$keys[0]`, the new code is strictly safer: `$keys[0]` emitted a notice on an empty array, `array_key_first()` returns `null` quietly. Developed in #12790. Follow-up to r63297. Props Soean, mukesh27. See #65773. git-svn-id: https://develop.svn.wordpress.org/trunk@63567 602fd350-edb4-49c9-b593-d223f7449a82
…Icon`. Props mayur8991, harishtewari, logicrays, sabernhardt. Fixes #65940. git-svn-id: https://develop.svn.wordpress.org/trunk@63568 602fd350-edb4-49c9-b593-d223f7449a82
This changeset ensures these external links declaration is consistent with WordPress/PHP Documentation Standards. See #65860. git-svn-id: https://develop.svn.wordpress.org/trunk@63569 602fd350-edb4-49c9-b593-d223f7449a82
`WP::handle_404()` sets a 404 when the main query matches no posts and no exception applies. Sitemap requests were never among those exceptions; they were shielded only incidentally, by falling through to `is_home`, and in r62664 that fallthrough was removed. A site with no published posts therefore served a complete, valid sitemap under a 404 status, which search engines discard. Exempt sitemap and stylesheet routes there, alongside the existing admin, robots and favicon exceptions. Since `handle_404()` no longer decides the status for these requests, every sitemap 404 now has to be issued by `WP_Sitemaps::render_sitemaps()` instead: an unregistered provider, an unrecognized stylesheet type, and a route whose query vars do not survive `sanitize_text_field()` would each otherwise be served as a 200 on an arbitrary URL. These share a `send_404()` helper, which also sends the no-cache headers `handle_404()` was previously contributing, so an intermediary does not retain a 404 for a route that becomes valid once the site has more content. Sitemaps disabled via the `wp_sitemaps_enabled` filter, and providers with an empty URL list, keep the status they already had; whether the latter should render an empty sitemap instead is #61293. Developed in #13247. Follow-up to r48072, r48523, r62664. Props iamchitti, westonruter, fernandot, wildworks, harishtewari, l1onofjudah, luksusspokoju, abrahamfariaz, andreasca, siliconforks, adamsilverstein, audrasjb, ocean90, mrkenobi. See #39157, #61293. Fixes #65945. git-svn-id: https://develop.svn.wordpress.org/trunk@63570 602fd350-edb4-49c9-b593-d223f7449a82
Also, sorts the rules alphabetically in `.eslintrc-jsdoc.js`. Part of the effort to improve JS inline documentation for 7.2. Developed in #13473 See #66033. git-svn-id: https://develop.svn.wordpress.org/trunk@63577 602fd350-edb4-49c9-b593-d223f7449a82
Props oandregal, ntsekouras. Part of #65981. git-svn-id: https://develop.svn.wordpress.org/trunk@63578 602fd350-edb4-49c9-b593-d223f7449a82
`WP_Scripts::get_data()` returns `false` when a handle has no `before` or `after` data, and casting that to an array produced `array( false )`. The first inline script added for a handle was therefore stored after an unused `false` entry. Missing inline script data is now treated as an empty array. Developed in: #12217 Follow-up to r36633. Props vanyukov, sukhendu2002, jonsurrell, apermo. Fixes #52320. git-svn-id: https://develop.svn.wordpress.org/trunk@63579 602fd350-edb4-49c9-b593-d223f7449a82
Prevent possible fatal errors on bad cached values by validating the caches is an array of strings. Developed in: #13429 Props josephscott, jonsurrell. Fixes #66063. git-svn-id: https://develop.svn.wordpress.org/trunk@63580 602fd350-edb4-49c9-b593-d223f7449a82
Developed in #13470. Follow-up to r43216. Props hbhalodia, dhruvang21, afercia, sabernhardt. Fixes #66085. git-svn-id: https://develop.svn.wordpress.org/trunk@63581 602fd350-edb4-49c9-b593-d223f7449a82
…ssword is added. This introduces a filterable email notification so users get alerted when an application password is added to their account. The email can be filtered via the `wp_application_password_created_email` filter and disabled via the `wp_send_application_password_created_email` filter. Props prasadkarmalkar, johnbillion, audrasjb. Developed in #9795 Fixes #63927 git-svn-id: https://develop.svn.wordpress.org/trunk@63582 602fd350-edb4-49c9-b593-d223f7449a82
Log the workflow run, pull request, Trac ticket, and SVN changeset URLs handled by the automation workflows. Report skipped reruns and empty pull request searches, and avoid processing the same pull request more than once. Await comment creation so failures are reported and success notices reflect completed requests. Developed in: #11223 Props arkaprabhachowdhury, adrianmoldovanwp, desrosj. Fixes #64299. git-svn-id: https://develop.svn.wordpress.org/trunk@63583 602fd350-edb4-49c9-b593-d223f7449a82
Test MySQL 5.7, 8.0, and 8.4 and MariaDB 5.5, 10.6, 10.11, 11.4, and 11.8 on pushes, pull requests, and manual runs. Keep the complete database matrix on the weekly schedule. Reduce routine coverage from 86 to 68 jobs while retaining the 182-job weekly matrix. Preserve the reporting, memcached, alternate-domain, HTML API, innovation-release, and PHP prerelease configurations. Developed in: #13447 Props lucatume, adrianmoldovanwp. Fixes #66069. git-svn-id: https://develop.svn.wordpress.org/trunk@63584 602fd350-edb4-49c9-b593-d223f7449a82
Allow reviewers to trigger the weekly PHP and database matrix on eligible pull requests by adding the Full PHPUnit Matrix label. Keep full coverage on subsequent commits while the label remains. Use a separate label-triggered workflow so unrelated labels do not replace PHPUnit checks or cancel active runs. Preserve the existing path filters and document the manual request process for contributors without label access. Developed in: #13448 Props lucatume, adrianmoldovanwp. Fixes #66071. git-svn-id: https://develop.svn.wordpress.org/trunk@63585 602fd350-edb4-49c9-b593-d223f7449a82
Delete attachments before the bulk database cleanup so their uploaded files and generated image sizes are removed while attachment metadata is still available. Preserve the existing bulk SQL cleanup for other records. Add regression coverage for attachment file and post deletion. Developed in: #8898 Props sirlouen, johnbillion, adrianmoldovanwp. Fixes #41978. git-svn-id: https://develop.svn.wordpress.org/trunk@63586 602fd350-edb4-49c9-b593-d223f7449a82
Discard the roles object loaded before the test tables are dropped. Let WordPress recreate it from the fresh tables so capabilities from a previous test run do not survive reinstallation. Developed in: #13286 Props ekamran. Fixes #65972. git-svn-id: https://develop.svn.wordpress.org/trunk@63590 602fd350-edb4-49c9-b593-d223f7449a82
Check all HTML5 named character references within each token map test instead of running a separate test for every token. Preserve the per-token assertions and include token names in failure messages. Reduce test invocations from 4,474 to 14, avoiding repeated test runner setup and teardown. Developed in: #13478 Props sainathpoojary. See #66074. git-svn-id: https://develop.svn.wordpress.org/trunk@63591 602fd350-edb4-49c9-b593-d223f7449a82
Clear the global comment fixture after author URL link tests and reset the comment-loop flag between tests to prevent order-dependent failures. Developed in: #13186 Props jonsurrell. See #65893. git-svn-id: https://develop.svn.wordpress.org/trunk@63592 602fd350-edb4-49c9-b593-d223f7449a82
Register core Ajax callbacks during each test setup so restoring the shared hook snapshot cannot leave later tests without their required callbacks. Remove the automatic update checks from admin_init during each setup as well. Developed in: #13191 Props jonsurrell. See #65893. git-svn-id: https://develop.svn.wordpress.org/trunk@63593 602fd350-edb4-49c9-b593-d223f7449a82
Flush rewrite rules after registering the initial taxonomies in conditional-query test setup. Clear the HTTPS server flag during rewrite test teardown so later tests do not inherit it. Developed in: #13193 Props jonsurrell. See #65893. git-svn-id: https://develop.svn.wordpress.org/trunk@63594 602fd350-edb4-49c9-b593-d223f7449a82
Save the incoming stylesheet in block and theme test fixtures and switch back during teardown when it changes. Restore the theme before database rollback so theme-related runtime state and caches do not leak into later tests. Developed in: #13205 Props jonsurrell. See #65893. git-svn-id: https://develop.svn.wordpress.org/trunk@63595 602fd350-edb4-49c9-b593-d223f7449a82
The PHP inline documentation standards call for `bool` and `int` in `@param`, `@return` and `@global` tags, but six docblocks in `src/wp-includes` still carried the long `boolean` and `integer` spellings. Developed in #13476. Follow-up to r63495. Props njones35. See #65860. git-svn-id: https://develop.svn.wordpress.org/trunk@63596 602fd350-edb4-49c9-b593-d223f7449a82
…er.json`. There are `LIBXML_*` constants conditionally used in SimplePie, ID3, and PHPUnit tests. Follow-up to r63004. See #65819, #65571. git-svn-id: https://develop.svn.wordpress.org/trunk@63597 602fd350-edb4-49c9-b593-d223f7449a82
Enables the JSDoc rule `require-param-description` and fixes all the reported violations. Part of the effort to improve JS inline documentation for 7.2. Developed in #13475 Props afercia, westonruter. See #66033. git-svn-id: https://develop.svn.wordpress.org/trunk@63598 602fd350-edb4-49c9-b593-d223f7449a82
The PHP inline documentation standards require a blank line between the `@since` tag and the following `@param`/`@return` tags. Developed in: #13482 Props mukesh27, wildworks. See #65818. git-svn-id: https://develop.svn.wordpress.org/trunk@63599 602fd350-edb4-49c9-b593-d223f7449a82
…ation blocks. Enables the following JSDoc rules: - `jsdoc/check-alignment` - `jsdoc/check-indentation` - `jsdoc/check-line-alignment` - `jsdoc/require-hyphen-before-param-description` -> never Fixes all the reported violations. Also removes hyphens before descriptions. Part of the effort to improve JS inline documentation for 7.2. Developed in #13490 Props afercia, mukesh27. See #66033. git-svn-id: https://develop.svn.wordpress.org/trunk@63600 602fd350-edb4-49c9-b593-d223f7449a82
Two methods used a ternary that treats a falsy value as not provided even though the parameters accept `0` as valid input, so this switches to the null coalescing operator, which tests only for `null`. Developed in: #13484 Props mukesh27, wildworks. See #65818. git-svn-id: https://develop.svn.wordpress.org/trunk@63601 602fd350-edb4-49c9-b593-d223f7449a82
…witches a flex layout to horizontal. `row` is the flex default, so the base layout never declares it. When a Tablet or Mobile override switched a vertical (Stack) layout to horizontal, the base `flex-direction: column` kept applying and the block stayed vertical. Backports WordPress/gutenberg#82364. Developed in #13370. Props jorgefilipecosta, talldanwp, firdaus666. Fixes #66096. git-svn-id: https://develop.svn.wordpress.org/trunk@63602 602fd350-edb4-49c9-b593-d223f7449a82
Add a 'blog' case to get_object_subtype() so register_meta() can resolve subtypes for site meta, matching the support already in place for posts, terms, comments, and users. Introduce register_site_meta() and unregister_site_meta() wrapper functions for registering and unregistering meta for sites, consistent with the existing site meta wrapper functions. Props sainathpoojary, spacedmonkey, flixos90, johnbillion. Fixes #44387. git-svn-id: https://develop.svn.wordpress.org/trunk@63603 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same. Where a loose comparison is intentional, inline comments now explain why: post meta returns IDs as strings, and some objects are compared by value. Developed in: #13451 Props r1k0, mukesh27. See #64895. git-svn-id: https://develop.svn.wordpress.org/trunk@63604 602fd350-edb4-49c9-b593-d223f7449a82
This is just a documentation change, as support for screencast.com has already been removed as of WordPress 6.8.2. This commit updates the list of supported providers in the `oembed_providers` filter DocBlock to reflect that change. Developed in #13479. Follow-up to r60345. Props maheshpawar2012, westonruter, SergeyBiryukov. Fixes #66090. git-svn-id: https://develop.svn.wordpress.org/trunk@63605 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )