chore(lint): report className restyling of components/ui exports

[juliusmarminge]

Problem

App code keeps restyling components/ui exports with ad-hoc className overrides instead of using the variants and sizes those components expose. That is where most of the visual inconsistency comes from, and it compounds: agents add a few per PR. An AST census of apps/web/src shows 837 override sites across 183 files today, up from 125 → 448 over the previous 180 days, growing in step with codebase size.

Fix

This PR is the guardrail only; migrating existing overrides to variants is follow-up work.

• Enable shadcn/no-restyle with allow: ["layout"] as a warning for apps/web/src, scoped outside components/ui itself. Layout classes (w-full, flex-1, ml-auto, absolute) stay allowed because placement belongs to the parent; color, typography, spacing, shape, effects, and motion overrides are reported. The plugin reads apps/web/components.json, resolves ~/components/ui, traces app wrappers that forward className, and names the component's real cva variants in each message:

  "py-0" is not allowed on <Badge>: <Badge> owns its spacing. Use a size (control, default, lg, sm), or margin here or gap on the parent for space around it. Add a size in apps/web/src/components/ui/badge.tsx only if the design explicitly calls for one.

• Add scripts/lint-restyle-ceiling.ts, run in the CI check job after vp check. It counts no-restyle findings from vp lint --format json and fails when they exceed the ceiling, currently the measured 1247. Lower RESTYLE_CEILING as files migrate; delete the script when the rule flips to error. This follows the same debt-ceiling pattern as no-manual-effect-runtime-in-tests in vite.config.ts.

• Bump vite-plus 0.3.0 → 0.3.3 (oxlint 1.79 → 1.83); the plugin needs oxlint ≥ 1.80.

• One line in AGENTS.md "Taste" so agents read the rule before writing JSX.

Verification

• vp run lint:restyle-ceiling → shadcn(no-restyle): 1247 findings, at the ceiling. exit 0.
• Regression check: adding className="text-red-500 rounded-full" to one <Button> → 1249 findings exceed the ceiling of 1247 exit 1.
• vp test run scripts/lint-restyle-ceiling.test.ts (2 tests), vp check on touched files, scripts and apps/web typecheck clean, web components/ui unit tests pass under the bumped vite-plus.
• Full vp lint goes from ~13s to ~16s locally with the plugin.

No UI change, so no screenshots.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code

---

Summary by CodeRabbit

• Chores

  • Added automated checks to monitor component styling overrides and enforce configured limits.
  • Updated linting configuration to identify inconsistent styling patterns while allowing layout-related classes.
  • CI now reports when styling findings exceed the accepted threshold.

• Tests

  • Added coverage for counting styling findings and validating threshold behavior.
  • Improved reliability of event-processing test coverage.

• Documentation

  • Documented guidance for using component variants and sizes instead of overriding styles at usage sites.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+14 B (+0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	0 B (0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.5 KiB	+14 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.3 KiB	56.3 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	−3 B (−0.0%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	−2 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−1 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: e65bc1c · PR result: 29afdc6 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is primarily a lint/CI guardrail with no intended product runtime change, but it adds a warning-only static-analysis rule with explicit exemptions and a separate ceiling check. The configuration-level relaxation of lint enforcement requires human review.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: cb13b6d4-1d13-4325-a9e4-75bcfa70edb2

📥 Commits

Reviewing files that changed from the base of the PR and between a9ffc90 and 29afdc6.

📒 Files selected for processing (1)

• apps/server/src/provider/Layers/OpenCodeAdapter.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The pull request configures Shadcn restyle linting, adds a ceiling of 1,247 findings, tests the ceiling logic, and runs the check in CI. It also updates an iterator mock in a server test.

Changes

Restyle linting

Layer / File(s)	Summary
Configure restyle linting vite.config.ts, package.json, pnpm-workspace.yaml	The lint configuration enables @shadcn/lint, maps ui to the shared component path, and warns on non-layout restyling outside that path. Supporting package versions and release exclusions are updated.
Implement and test the ceiling gate scripts/lint-restyle-ceiling.ts, scripts/lint-restyle-ceiling.test.ts, package.json	The gate runs the web linter in JSON mode, counts shadcn(no-restyle) findings, and fails when the count exceeds 1247. Tests cover filtering and ceiling boundaries.
Enforce the gate and document the rule .github/workflows/ci.yml, AGENTS.md	CI runs lint:restyle-ceiling. Repository guidance requires shared UI styling through component variants or sizes and places layout classes on parents.
Preserve iterator binding in the server test apps/server/src/provider/Layers/OpenCodeAdapter.test.ts	The Map.prototype.values mock binds the original iterator next method before wrapping it and retains history-part visitation tracking.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 29afd

This change adds lint enforcement and a CI ceiling without evidenced correctness, security, data-integrity, availability, or deployment risk, so it is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: adding lint reporting for className restyling of components/ui exports.
Description check	✅ Passed	The description explains the problem, the guardrail implementation, CI ceiling, verification steps, and the absence of UI changes. It does not use the template headings or include the checklist, but i…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}