fix(web): device Reconnect starts one stream instead of two

[juliusmarminge]

Follow-up from the #12639 audit.

The web device viewer's Reconnect button called `refreshDeviceHubAccess` and then stopped and restarted the stream client by hand. The access atom's refresh yields a new `AsyncResult` object, `useDeviceHubAccess` memoizes on that object, and the viewer's effect depends on `access`, so the refresh alone already tears down the client and creates a fresh one. The manual restart therefore connected to the helper (MJPEG prime, input socket, video) and was discarded moments later, for two full connection attempts per press. The existing test could not see this because it mocked `refreshDeviceHubAccess` as a no-op.

Drop the refresh and keep the restart. This is not a regression for expired tickets: a rejected restart hits the transport's unauthorized path, which refreshes access and reconnects through the effect, the same way it does for any 401 today.

Verification:

• The web viewer test's `~/state/device` mock now behaves like the real atom (refresh produces a new access object and re-renders). With that mock, the pre-fix component fails both the existing Reconnect test (the manually started client's image is torn down before it gets a source) and a new test that counts one helper prime per Reconnect press (it saw 3 instead of 2). Both pass here.
• `apps/web` device tests 3/3, lint, format, and web typecheck clean on the changed files.

Visually identical (same button, same overlay), so no screenshots; the difference is one fewer connection cycle against the helper.

Prepared with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code

---

Summary by CodeRabbit

• Bug Fixes
  • Improved device stream reconnection when access credentials have expired.
  • Reconnecting now refreshes access through the stream client’s authorization handling, helping prevent redundant access requests and ensuring the stream restarts correctly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: aa0e1f86-9bf8-4d1d-8346-5e2cb09c9ae0

📥 Commits

Reviewing files that changed from the base of the PR and between 9f73ca3 and 382fa0e.

📒 Files selected for processing (2)

• apps/web/src/components/device/DeviceStreamView.test.tsx
• apps/web/src/components/device/DeviceStreamView.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The reconnect flow no longer refreshes device access directly. The test mock now supports subscriptions and refresh notifications, and the tests verify the initial and reconnect request counts.

Changes

Reconnect access refresh

Layer / File(s)	Summary
Reconnect flow and request-count validation apps/web/src/components/device/DeviceStreamView.tsx, apps/web/src/components/device/DeviceStreamView.test.tsx	Reconnect now restarts the client without directly refreshing access. The test mock uses a subscribable external store, tracks prime requests, and verifies one initial request plus one additional request after reconnect.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary fix: Reconnect now starts one stream instead of two.
Description check	✅ Passed	The description clearly explains what changed, why the duplicate connection occurred, how expired tickets remain supported, and how the change was verified. It does not include the template's Checklis…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+38 B (+0.3%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.5 KiB	+36 B (+0.5%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.2 KiB	56.3 KiB	+44 B (+0.1%)	66.4 KiB	✅
Codex	Live turn messages	9	10	+1 (+11.1%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	−24 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	−10 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−14 B (−0.2%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: 9f73ca3 · PR result: 382fa0e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at 382fa0e

Macroscope's review found this PR approvable — This is a small, well-contained device-stream bug fix that removes a redundant reconnect cycle while preserving expired-ticket recovery through the existing unauthorized flow. Regression tests now model access refreshes and verify that each reconnect starts exactly one new stream.

^{You can add or adjust custom eligibility rules. Learn more.}