fix(bitbucket): preserve rate limits from optional PR reads

[juliusmarminge]

Optional Bitbucket PR reads currently turn HTTP 429 errors into empty or unknown results. Preserve rate-limit failures and Retry-After timestamps, including when reading the error body fails, so callers can back off correctly. Other optional-read failures retain their existing fallback behavior.

Ported from V2 without the separate checks-query API. All 38 focused provider/API tests, server typecheck, and targeted lint pass. Tests cover each optional read for both ordinary response errors and unreadable error bodies. No visual UI change.

Model: GPT-6. Harness: Codex.

---

Summary by CodeRabbit

• Bug Fixes
  • Improved Bitbucket rate-limit handling so 429 errors consistently preserve retry timing, including when response details cannot be read.
  • Improved pull request data loading during certain Bitbucket read failures, allowing non-rate-limit failures to fall back gracefully while continuing to display available information.
  • Improved handling of Bitbucket 403 responses so affected optional pull request details can continue processing without blocking the request.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: aa45b3d9-bc3e-419e-9552-691912dd492e

📥 Commits

Reviewing files that changed from the base of the PR and between ccad9f6 and 718fbce.

📒 Files selected for processing (4)

• apps/server/src/pullRequest/BitbucketPullRequestProvider.test.ts
• apps/server/src/pullRequest/BitbucketPullRequestProvider.ts
• apps/server/src/sourceControl/BitbucketApi.test.ts
• apps/server/src/sourceControl/BitbucketApi.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

Bitbucket errors now preserve retryAt when response-body reads fail. Optional pull-request reads propagate 429 failures and recover non-rate-limit failures with existing defaults. Tests cover both behaviors.

Changes

Bitbucket rate-limit handling

Layer / File(s)	Summary
API retry metadata apps/server/src/sourceControl/BitbucketApi.ts, apps/server/src/sourceControl/BitbucketApi.test.ts	BitbucketResponseBodyReadError now carries retryAt. The API computes the retry timestamp once and reuses it for response errors and body-read errors.
Pull-request read recovery apps/server/src/pullRequest/BitbucketPullRequestProvider.ts, apps/server/src/pullRequest/BitbucketPullRequestProvider.test.ts	Optional mergeability, checks, repository permission, comment, and commit reads propagate status-429 failures. Other read failures return their existing fallback values. Tests cover response and body-read failures for 429 and 403 responses.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: bil0000

Merge Risk: ⚪ Minimal · up to 718fb

The change has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes preserving rate-limit failures from optional Bitbucket pull-request reads.
Description check	✅ Passed	The description explains what changed, why it changed, test coverage, and that no UI changes are included. It does not use the template headings or include the checklist, but the required information …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+25 B (+0.2%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	+8 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+17 B (+0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.2 KiB	56.3 KiB	+44 B (+0.1%)	66.4 KiB	✅
Codex	Live turn messages	9	10	+1 (+11.1%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+28 B (+0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	+10 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.5 KiB	+18 B (+0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.1 KiB	+44 B (+0.1%)	66.4 KiB	✅
Claude	Live turn messages	9	10	+1 (+11.1%)	21	✅

Baseline: ccad9f6 · PR result: 718fbce · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at 718fbce

Macroscope's review found this PR approvable — This is a focused Bitbucket rate-limit bug fix with explicit tests for response and response-body read failures across all affected optional reads. Non-rate-limit fallbacks remain unchanged, and the PR introduces no default, deployment, security, or static-analysis changes.

^{You can add or adjust custom eligibility rules. Learn more.}